Update patch set 3

Patch Set 3: Code-Review+2 Workflow+1

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 6737 <6737@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 72be1cc78e4f46dea475fec23528bc916b747aa2
Label: Workflow=+1, 122f52dd4d883eb3c7ea098d0b2981fadd0e8419

ab565c71bd174cdda1fc58446afc985ccf4d92a6

@@ -16,6 +16,46 @@
       "message": "Figured out that the files being written in the pools.yaml were still using the unit name instead of the application name so modified those accordingly as well as the tests.\nDuring my testing I also found out that we need to restart the designate-worker service when we are upgrading the charm so that it loads the new configuration.",
       "revId": "ab565c71bd174cdda1fc58446afc985ccf4d92a6",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "80d3bea1_321a60fb",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 3
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 6737
+      },
+      "writtenOn": "2024-03-25T16:55:26Z",
+      "side": 1,
+      "message": "lgtm",
+      "revId": "ab565c71bd174cdda1fc58446afc985ccf4d92a6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "bcde93be_18e0aea5",
+        "filename": "src/lib/charm/openstack/designate.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 90,
+      "author": {
+        "id": 6737
+      },
+      "writtenOn": "2024-03-25T16:55:26Z",
+      "side": 1,
+      "message": "personally i would have done:\n\napplication_name \u003d slave[\u0027unit\u0027].rpartition(\u0027/\u0027)[0].replace(\u0027-\u0027, \u0027_\u0027)\n\nbut its giving the same i think so all good.",
+      "range": {
+        "startLine": 90,
+        "startChar": 45,
+        "endLine": 90,
+        "endChar": 50
+      },
+      "revId": "ab565c71bd174cdda1fc58446afc985ccf4d92a6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }