From 078948a454a42dc8ba33418d7507c31d37c4e7e4 Mon Sep 17 00:00:00 2001
From: Gerrit User 14567 <14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Fri, 22 Mar 2024 15:07:21 +0000
Subject: [PATCH] Update patch set 2

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 14567 <14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 477b692405a24101eb558c89f077ceccca42bf61
---
 07da644b2ba6a2371cf7ef5249e196f18a3b8823 | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/07da644b2ba6a2371cf7ef5249e196f18a3b8823 b/07da644b2ba6a2371cf7ef5249e196f18a3b8823
index bee92d05..a1864c3f 100644
--- a/07da644b2ba6a2371cf7ef5249e196f18a3b8823
+++ b/07da644b2ba6a2371cf7ef5249e196f18a3b8823
@@ -16,6 +16,29 @@
       "message": "recheck\n\nthe constraint was updated - https://github.com/openstack-charmers/zaza-openstack-tests/pull/1194",
       "revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "0f642968_7cb4996a",
+        "filename": "hooks/glance_contexts.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 379,
+      "author": {
+        "id": 14567
+      },
+      "writtenOn": "2024-03-22T15:07:21Z",
+      "side": 1,
+      "message": "there is no else to this IF. So, if cinder_volume_types is used, and there is no keystone_ctx to fill the other properties, then it will arrive at an error state that is causing the bug. Shouldn\u0027t it print an error message saying that there is a config problem or something so the error isn\u0027t triggered, and highlights that there is something to be fixed to the operator? If this is an error state that should not be ignored, we could raise an exception here and let the charm status be error so the operator fixes it.",
+      "range": {
+        "startLine": 379,
+        "startChar": 20,
+        "endLine": 379,
+        "endChar": 36
+      },
+      "revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file