From 7ba8dc312ac21c5af58ffa9733e0860cad05675f Mon Sep 17 00:00:00 2001
From: Gerrit User 34275 <34275@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Fri, 22 Mar 2024 16:53:50 +0000
Subject: [PATCH] Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 14567 \u003c14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34275\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34275 \u003c34275@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34275\u003e replied on the change"}
---
 07da644b2ba6a2371cf7ef5249e196f18a3b8823 | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/07da644b2ba6a2371cf7ef5249e196f18a3b8823 b/07da644b2ba6a2371cf7ef5249e196f18a3b8823
index a1864c3f..6fe7db39 100644
--- a/07da644b2ba6a2371cf7ef5249e196f18a3b8823
+++ b/07da644b2ba6a2371cf7ef5249e196f18a3b8823
@@ -39,6 +39,30 @@
       },
       "revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1a0e1da6_2a07e7cb",
+        "filename": "hooks/glance_contexts.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 379,
+      "author": {
+        "id": 34275
+      },
+      "writtenOn": "2024-03-22T16:53:50Z",
+      "side": 1,
+      "message": "The thing is this code is executed several times as the relations between this charm and others are gradually being completed. Sometimes a partial version of this file (glance-api.conf) is generated first before the identity relation with keystone is established so it will lack the [keystone-authtoken] section and also these extra parameters. After the relation is established the file is generated again and in this case includes the extra fields (and the [kesytone-authtoken] section).\nThus, the if line is needed or otherwise the code will fail when the file is generated before the relation with keystone is complete.",
+      "parentUuid": "0f642968_7cb4996a",
+      "range": {
+        "startLine": 379,
+        "startChar": 20,
+        "endLine": 379,
+        "endChar": 36
+      },
+      "revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file