ed8bdede6f
Add standard configuration options for erasure coded pool creation and profile configuration. Update ceph relation joined handled to support erasure coded pools - a replicated pool is created at 1% of the total data weight alongside the erasure coding profile and supporting erasure coded data pool. Update ceph context to use the metadata pool name in the glance configuration files when erasure-coded pool-type is configured. Resync charmhelpers to update Ceph Broker request support for erasure coding. Change-Id: If4a31a2adf8080af66885adb970fbb3cdd82f573 Depends-On: Iec4de19f7b39f0b08158d96c5cc1561b40aefa10
808 lines
34 KiB
Python
808 lines
34 KiB
Python
# Copyright 2016 Canonical Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import importlib
|
|
import os
|
|
import sys
|
|
|
|
from mock import call, patch, MagicMock
|
|
from test_utils import CharmTestCase
|
|
|
|
# python-apt is not installed as part of test-requirements but is imported by
|
|
# some charmhelpers modules so create a fake import.
|
|
mock_apt = MagicMock()
|
|
sys.modules['apt'] = mock_apt
|
|
mock_apt.apt_pkg = MagicMock()
|
|
|
|
os.environ['JUJU_UNIT_NAME'] = 'glance'
|
|
|
|
import glance_utils as utils # noqa
|
|
|
|
_reg = utils.register_configs
|
|
_map = utils.restart_map
|
|
|
|
utils.register_configs = MagicMock()
|
|
utils.restart_map = MagicMock()
|
|
|
|
|
|
with patch('charmhelpers.contrib.hardening.harden.harden') as mock_dec:
|
|
mock_dec.side_effect = (lambda *dargs, **dkwargs: lambda f:
|
|
lambda *args, **kwargs: f(*args, **kwargs))
|
|
with patch('charmhelpers.contrib.openstack.'
|
|
'utils.os_requires_version') as mock_os:
|
|
mock_os.side_effect = (lambda *dargs, **dkwargs: lambda f:
|
|
lambda *args, **kwargs: f(*args, **kwargs))
|
|
with patch('glance_utils.register_configs') as register_configs:
|
|
with patch('glance_utils.restart_map') as restart_map:
|
|
import glance_relations as relations
|
|
importlib.reload(relations)
|
|
|
|
relations.hooks._config_save = False
|
|
|
|
utils.register_configs = _reg
|
|
utils.restart_map = _map
|
|
|
|
TO_PATCH = [
|
|
# charmhelpers.core.hookenv
|
|
'Hooks',
|
|
'config',
|
|
'juju_log',
|
|
'local_unit',
|
|
'open_port',
|
|
'relation_ids',
|
|
'relation_set',
|
|
'relation_get',
|
|
'related_units',
|
|
'service_name',
|
|
# charmhelpers.core.host
|
|
'apt_install',
|
|
'apt_update',
|
|
'restart_on_change',
|
|
'service_reload',
|
|
'service_stop',
|
|
'service_restart',
|
|
# charmhelpers.contrib.openstack.utils
|
|
'configure_installation_source',
|
|
'is_db_initialised',
|
|
'os_release',
|
|
'openstack_upgrade_available',
|
|
# charmhelpers.contrib.openstack.policyd
|
|
'maybe_do_policyd_overrides',
|
|
'maybe_do_policyd_overrides_on_config_changed',
|
|
# charmhelpers.contrib.openstack.ha.utils
|
|
'generate_ha_relation_data',
|
|
'is_clustered',
|
|
# charmhelpers.contrib.hahelpers.cluster_utils
|
|
'is_elected_leader',
|
|
# glance_utils
|
|
'restart_map',
|
|
'register_configs',
|
|
'do_openstack_upgrade',
|
|
'migrate_database',
|
|
'ensure_ceph_keyring',
|
|
'ceph_config_file',
|
|
'update_nrpe_config',
|
|
'reinstall_paste_ini',
|
|
'determine_packages',
|
|
'remove_old_packages',
|
|
'services',
|
|
# other
|
|
'call',
|
|
'check_call',
|
|
'execd_preinstall',
|
|
'lsb_release',
|
|
'filter_installed_packages',
|
|
'sync_db_with_multi_ipv6_addresses',
|
|
'delete_keyring',
|
|
'get_relation_ip',
|
|
'is_db_maintenance_mode',
|
|
]
|
|
|
|
|
|
class GlanceRelationTests(CharmTestCase):
|
|
|
|
def setUp(self):
|
|
super(GlanceRelationTests, self).setUp(relations, TO_PATCH)
|
|
self.config.side_effect = self.test_config.get
|
|
self.restart_on_change.return_value = None
|
|
self.os_release.return_value = 'icehouse'
|
|
|
|
def test_install_hook(self):
|
|
repo = 'cloud:precise-grizzly'
|
|
_packages = ['apache2', 'glance', 'haproxy', 'memcached',
|
|
'python-keystone', 'python-mysqldb', 'python-psycopg2',
|
|
'python-six', 'python-swiftclient', 'uuid']
|
|
self.test_config.set('openstack-origin', repo)
|
|
self.service_stop.return_value = True
|
|
self.determine_packages.return_value = _packages
|
|
relations.install_hook()
|
|
self.configure_installation_source.assert_called_with(repo)
|
|
self.apt_update.assert_called_with(fatal=True)
|
|
self.apt_install.assert_called_with(_packages, fatal=True)
|
|
self.assertTrue(self.execd_preinstall.called)
|
|
|
|
def test_install_hook_precise_distro(self):
|
|
self.test_config.set('openstack-origin', 'distro')
|
|
self.lsb_release.return_value = {'DISTRIB_RELEASE': 12.04,
|
|
'DISTRIB_CODENAME': 'precise'}
|
|
self.service_stop.return_value = True
|
|
relations.install_hook()
|
|
self.configure_installation_source.assert_called_with(
|
|
"cloud:precise-folsom"
|
|
)
|
|
|
|
def test_db_joined(self):
|
|
self.get_relation_ip.return_value = '10.0.0.1'
|
|
relations.db_joined()
|
|
self.relation_set.assert_called_with(database='glance',
|
|
username='glance',
|
|
hostname='10.0.0.1')
|
|
self.get_relation_ip.assert_called_with('shared-db', cidr_network=None)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_missing_relation_data(self, configs):
|
|
self.is_db_maintenance_mode.return_value = False
|
|
self.is_db_initialised.return_value = False
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = []
|
|
relations.db_changed()
|
|
self.juju_log.assert_called_with(
|
|
'shared-db relation incomplete. Peer not ready?'
|
|
)
|
|
|
|
def _shared_db_test(self, configs, unit_name,
|
|
allowed_units='glance/0 glance/3'):
|
|
self.is_db_maintenance_mode.return_value = False
|
|
self.relation_get.return_value = allowed_units
|
|
self.local_unit.return_value = unit_name
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['shared-db']
|
|
configs.write = MagicMock()
|
|
relations.db_changed()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_allowed(self, configs):
|
|
self.is_db_initialised.return_value = False
|
|
self._shared_db_test(configs, 'glance/0')
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf'),
|
|
call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_not_allowed(self, configs):
|
|
self.is_db_initialised.return_value = False
|
|
self._shared_db_test(configs, 'glance/2')
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf'),
|
|
call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.assertFalse(self.migrate_database.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_no_acls(self, configs):
|
|
self.is_db_initialised.return_value = False
|
|
self._shared_db_test(configs, 'glance/2', None)
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf'),
|
|
call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.assertFalse(self.migrate_database.called)
|
|
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_image_service_joined(self, configs, imgsj):
|
|
self.is_db_initialised.return_value = False
|
|
rids = ['nova-cloud-controller:1', 'nova-compute:1']
|
|
self.relation_ids.return_value = rids
|
|
self._shared_db_test(configs, 'glance/2', None)
|
|
[self.assertIn(call(r), imgsj.call_args_list) for r in rids]
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_with_essex_not_setting_version_control(self, configs):
|
|
self.is_db_initialised.return_value = False
|
|
self.os_release.return_value = "essex"
|
|
self.call.return_value = 0
|
|
self._shared_db_test(configs, 'glance/0')
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf')],
|
|
configs.write.call_args_list)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_db_changed_with_essex_setting_version_control(self, configs):
|
|
self.is_db_initialised.return_value = False
|
|
self.os_release.return_value = "essex"
|
|
self.call.return_value = 1
|
|
self._shared_db_test(configs, 'glance/0')
|
|
self.assertEqual([call('/etc/glance/glance-registry.conf')],
|
|
configs.write.call_args_list)
|
|
self.check_call.assert_called_with(
|
|
["glance-manage", "version_control", "0"]
|
|
)
|
|
self.juju_log.assert_called_with(
|
|
'Cluster leader, performing db sync'
|
|
)
|
|
self.migrate_database.assert_called_with()
|
|
|
|
@patch.object(relations, 'is_api_ready')
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_image_service_joined_leader(self, _canonical_url, _api_ready):
|
|
_api_ready.return_value = True
|
|
_canonical_url.return_value = 'http://glancehost'
|
|
relations.image_service_joined()
|
|
args = {
|
|
'glance-api-ready': 'yes',
|
|
'glance-api-server': 'http://glancehost:9292',
|
|
'relation_id': None
|
|
}
|
|
self.relation_set.assert_called_with(**args)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_image_service_joined_specified_interface(self, _canonical_url):
|
|
_canonical_url.return_value = 'http://glancehost'
|
|
relations.image_service_joined(relation_id='image-service:1')
|
|
args = {
|
|
'glance-api-ready': 'no',
|
|
'glance-api-server': 'http://glancehost:9292',
|
|
'relation_id': 'image-service:1',
|
|
}
|
|
self.relation_set.assert_called_with(**args)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_object_store_joined_without_identity_service(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['']
|
|
configs.write = MagicMock()
|
|
relations.object_store_joined()
|
|
self.juju_log.assert_called_with(
|
|
'Deferring swift storage configuration until '
|
|
'an identity-service relation exists'
|
|
)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_object_store_joined_with_identity_service_without_object_store(
|
|
self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service']
|
|
configs.write = MagicMock()
|
|
relations.object_store_joined()
|
|
self.juju_log.assert_called_with(
|
|
'swift relation incomplete'
|
|
)
|
|
|
|
@patch.object(relations, 'update_image_location_policy')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_object_store_joined_with_identity_service_with_object_store(
|
|
self, configs, mock_update_image_location_policy):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service',
|
|
'object-store']
|
|
configs.write = MagicMock()
|
|
relations.object_store_joined()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.assertTrue(mock_update_image_location_policy.called)
|
|
|
|
@patch.object(relations, 'update_image_location_policy')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_object_store_joined_with_expose_image_locations_false(
|
|
self, configs, mock_update_image_location_policy):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service',
|
|
'object-store']
|
|
configs.write = MagicMock()
|
|
relations.object_store_joined()
|
|
self.assertTrue(mock_update_image_location_policy.called)
|
|
|
|
def test_ceph_joined(self):
|
|
relations.ceph_joined()
|
|
self.apt_install.assert_called_with(['ceph-common'])
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_changed_missing_relation_data(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = []
|
|
configs.write = MagicMock()
|
|
relations.ceph_changed()
|
|
self.juju_log.assert_called_with(
|
|
'ceph relation incomplete. Peer not ready?'
|
|
)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_changed_no_keyring(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['ceph']
|
|
configs.write = MagicMock()
|
|
self.ensure_ceph_keyring.return_value = False
|
|
relations.ceph_changed()
|
|
self.juju_log.assert_called_with(
|
|
'Could not create ceph keyring: peer not ready?'
|
|
)
|
|
|
|
@patch.object(relations, 'get_ceph_request')
|
|
@patch.object(relations, 'send_request_if_needed')
|
|
@patch.object(relations, 'is_request_complete')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_changed_broker_send_rq(self, configs, mock_request_complete,
|
|
mock_send_request_if_needed,
|
|
mock_get_ceph_request):
|
|
self.service_name.return_value = 'glance'
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['ceph']
|
|
mock_get_ceph_request.return_value = 'cephrq'
|
|
self.ensure_ceph_keyring.return_value = True
|
|
mock_request_complete.return_value = False
|
|
relations.hooks.execute(['hooks/ceph-relation-changed'])
|
|
self.ensure_ceph_keyring.assert_called_with(service='glance',
|
|
user='glance',
|
|
group='glance')
|
|
for c in [call('/etc/glance/glance.conf')]:
|
|
self.assertNotIn(c, configs.write.call_args_list)
|
|
|
|
@patch('charmhelpers.contrib.storage.linux.ceph.CephBrokerRq'
|
|
'.add_op_request_access_to_group')
|
|
@patch('charmhelpers.contrib.storage.linux.ceph.CephBrokerRq'
|
|
'.add_op_create_pool')
|
|
def test_create_pool_op(self, mock_create_pool,
|
|
mock_request_access):
|
|
self.service_name.return_value = 'glance'
|
|
self.test_config.set('ceph-osd-replication-count', 3)
|
|
self.test_config.set('ceph-pool-weight', 6)
|
|
relations.get_ceph_request()
|
|
mock_create_pool.assert_called_once_with(
|
|
name='glance',
|
|
replica_count=3,
|
|
weight=6,
|
|
group='images',
|
|
app_name='rbd')
|
|
mock_request_access.assert_not_called()
|
|
|
|
self.test_config.set('restrict-ceph-pools', True)
|
|
relations.get_ceph_request()
|
|
mock_create_pool.assert_called_with(name='glance', replica_count=3,
|
|
weight=6, group='images',
|
|
app_name='rbd')
|
|
mock_request_access.assert_has_calls([
|
|
call(
|
|
name='images',
|
|
object_prefix_permissions={'class-read': ['rbd_children']},
|
|
permission='rwx'),
|
|
])
|
|
|
|
@patch('charmhelpers.contrib.storage.linux.ceph.CephBrokerRq'
|
|
'.add_op_create_erasure_pool')
|
|
@patch('charmhelpers.contrib.storage.linux.ceph.CephBrokerRq'
|
|
'.add_op_create_erasure_profile')
|
|
@patch('charmhelpers.contrib.storage.linux.ceph.CephBrokerRq'
|
|
'.add_op_request_access_to_group')
|
|
@patch('charmhelpers.contrib.storage.linux.ceph.CephBrokerRq'
|
|
'.add_op_create_pool')
|
|
def test_create_ec_pool_op(self, mock_create_pool,
|
|
mock_request_access,
|
|
mock_create_erasure_profile,
|
|
mock_create_erasure_pool):
|
|
self.service_name.return_value = 'glance'
|
|
self.test_config.set('ceph-osd-replication-count', 3)
|
|
self.test_config.set('ceph-pool-weight', 6)
|
|
self.test_config.set('pool-type', 'erasure-coded')
|
|
self.test_config.set('ec-profile-plugin', 'isa')
|
|
self.test_config.set('ec-profile-k', 6)
|
|
self.test_config.set('ec-profile-m', 2)
|
|
relations.get_ceph_request()
|
|
mock_create_pool.assert_called_once_with(
|
|
name='glance-metadata',
|
|
replica_count=3,
|
|
weight=0.06,
|
|
group='images',
|
|
app_name='rbd')
|
|
mock_create_erasure_profile.assert_called_once_with(
|
|
name='glance-profile',
|
|
k=6, m=2,
|
|
lrc_locality=None,
|
|
lrc_crush_locality=None,
|
|
shec_durability_estimator=None,
|
|
clay_helper_chunks=None,
|
|
clay_scalar_mds=None,
|
|
device_class=None,
|
|
erasure_type='isa',
|
|
erasure_technique=None,
|
|
)
|
|
mock_create_erasure_pool.assert_called_once_with(
|
|
name='glance',
|
|
erasure_profile='glance-profile',
|
|
weight=5.94,
|
|
group='images',
|
|
app_name='rbd',
|
|
allow_ec_overwrites=True)
|
|
mock_request_access.assert_not_called()
|
|
|
|
@patch.object(relations, 'get_ceph_request')
|
|
@patch.object(relations, 'send_request_if_needed')
|
|
@patch.object(relations, 'is_request_complete')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_changed_key_and_relation_data(self, configs,
|
|
mock_request_complete,
|
|
mock_send_request_if_needed,
|
|
mock_service):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['ceph']
|
|
configs.write = MagicMock()
|
|
self.ensure_ceph_keyring.return_value = True
|
|
mock_request_complete.return_value = True
|
|
self.ceph_config_file.return_value = '/etc/ceph/ceph.conf'
|
|
relations.ceph_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf'),
|
|
call('/etc/ceph/ceph.conf')],
|
|
configs.write.call_args_list)
|
|
self.service_restart.assert_called_with('glance-api')
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_ceph_broken(self, configs):
|
|
self.service_name.return_value = 'glance'
|
|
relations.ceph_broken()
|
|
self.delete_keyring.assert_called_with(service='glance')
|
|
self.assertTrue(configs.write_all.called)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_keystone_joined(self, _canonical_url):
|
|
_canonical_url.return_value = 'http://glancehost'
|
|
relations.keystone_joined()
|
|
ex = {
|
|
'region': 'RegionOne',
|
|
'public_url': 'http://glancehost:9292',
|
|
'admin_url': 'http://glancehost:9292',
|
|
'service': 'glance',
|
|
'internal_url': 'http://glancehost:9292',
|
|
'relation_id': None,
|
|
}
|
|
self.relation_set.assert_called_with(**ex)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_keystone_joined_with_relation_id(self, _canonical_url):
|
|
_canonical_url.return_value = 'http://glancehost'
|
|
relations.keystone_joined(relation_id='identity-service:0')
|
|
ex = {
|
|
'region': 'RegionOne',
|
|
'public_url': 'http://glancehost:9292',
|
|
'admin_url': 'http://glancehost:9292',
|
|
'service': 'glance',
|
|
'internal_url': 'http://glancehost:9292',
|
|
'relation_id': 'identity-service:0',
|
|
}
|
|
self.relation_set.assert_called_with(**ex)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
def test_keystone_joined_public_endpoint(self, _canonical_url):
|
|
def fake_canonical_url(configs, endpoint_type):
|
|
return {"public": "http://glance.example.com",
|
|
"int": "http://glancehost",
|
|
"admin": "http://glancehost"}[endpoint_type]
|
|
_canonical_url.side_effect = fake_canonical_url
|
|
self.test_config.set('os-public-hostname', 'glance.example.com')
|
|
relations.keystone_joined()
|
|
ex = {
|
|
'region': 'RegionOne',
|
|
'public_url': 'http://glance.example.com:9292',
|
|
'admin_url': 'http://glancehost:9292',
|
|
'service': 'glance',
|
|
'internal_url': 'http://glancehost:9292',
|
|
'relation_id': None,
|
|
}
|
|
self.relation_set.assert_called_with(**ex)
|
|
|
|
def test_keystone_joined_partial_cluster(self):
|
|
self.is_clustered.return_value = False
|
|
self.test_config.set('vip', '10.0.0.10')
|
|
relations.keystone_joined()
|
|
self.assertFalse(self.relation_set.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_keystone_changes_incomplete(self, configs):
|
|
configs.complete_contexts.return_value = []
|
|
relations.keystone_changed()
|
|
self.assertTrue(self.juju_log.called)
|
|
self.assertFalse(configs.write.called)
|
|
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_keystone_changed_no_object_store_relation(self, configs,
|
|
configure_https):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = []
|
|
relations.keystone_changed()
|
|
configs.write_all.assert_called_once()
|
|
self.assertTrue(configure_https.called)
|
|
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'object_store_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_keystone_changed_with_object_store_relation(self,
|
|
configs,
|
|
object_store_joined,
|
|
configure_https,
|
|
image_service_joined):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.side_effect = [
|
|
['object-store:0'],
|
|
['image-service:0'],
|
|
]
|
|
relations.keystone_changed()
|
|
configs.write_all.assert_called_once()
|
|
object_store_joined.assert_called_with()
|
|
self.assertTrue(configure_https.called)
|
|
image_service_joined.assert_called_with('image-service:0')
|
|
|
|
@patch.object(relations, 'configure_https')
|
|
@patch.object(relations, 'object_store_joined')
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_keystone_changed_image_service_joined(self, configs, imgsj, osj,
|
|
https):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['identity-service']
|
|
|
|
rids = ['nova-cloud-controller:1', 'nova-compute:1']
|
|
self.relation_ids.return_value = rids
|
|
relations.keystone_changed()
|
|
[self.assertIn(call(r), imgsj.call_args_list) for r in rids]
|
|
|
|
@patch.object(relations, 'update_image_location_policy')
|
|
@patch.object(relations, 'configure_https')
|
|
def test_config_changed_no_openstack_upgrade(self,
|
|
configure_https,
|
|
mock_update_policy):
|
|
self.openstack_upgrade_available.return_value = False
|
|
relations.config_changed()
|
|
self.open_port.assert_called_with(9292)
|
|
self.assertTrue(configure_https.called)
|
|
self.assertTrue(mock_update_policy.called)
|
|
|
|
@patch.object(relations, 'update_image_location_policy')
|
|
@patch.object(relations, 'status_set')
|
|
@patch.object(relations, 'configure_https')
|
|
def test_config_changed_with_openstack_upgrade(self,
|
|
configure_https,
|
|
status,
|
|
mock_update_policy):
|
|
self.openstack_upgrade_available.return_value = True
|
|
relations.config_changed()
|
|
status.assert_called_with(
|
|
'maintenance',
|
|
'Upgrading OpenStack release'
|
|
)
|
|
self.assertTrue(self.do_openstack_upgrade.called)
|
|
self.assertTrue(configure_https.called)
|
|
self.assertTrue(mock_update_policy.called)
|
|
|
|
@patch.object(relations, 'update_image_location_policy')
|
|
def test_config_changed_with_openstack_upgrade_action(self,
|
|
mock_update_policy):
|
|
self.openstack_upgrade_available.return_value = True
|
|
self.test_config.set('action-managed-upgrade', True)
|
|
|
|
relations.config_changed()
|
|
self.assertFalse(self.do_openstack_upgrade.called)
|
|
self.assertTrue(mock_update_policy.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_cluster_changed(self, configs):
|
|
self.test_config.set('prefer-ipv6', False)
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['cluster']
|
|
configs.write = MagicMock()
|
|
relations.cluster_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf'),
|
|
call('/etc/haproxy/haproxy.cfg')],
|
|
configs.write.call_args_list)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'relation_set')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_cluster_changed_with_ipv6(self, configs, relation_set,
|
|
_canonical_url):
|
|
self.test_config.set('prefer-ipv6', True)
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['cluster']
|
|
configs.write = MagicMock()
|
|
self.get_relation_ip.return_value = '2001:db8:1::1'
|
|
self.relation_ids.return_value = ['cluster:0']
|
|
relations.cluster_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf'),
|
|
call('/etc/haproxy/haproxy.cfg')],
|
|
configs.write.call_args_list)
|
|
|
|
@patch.object(relations, 'update_image_location_policy')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_upgrade_charm(self, configs, mock_update_image_location_policy):
|
|
self.remove_old_packages.return_value = False
|
|
self.filter_installed_packages.return_value = ['test']
|
|
relations.upgrade_charm()
|
|
self.apt_install.assert_called_with(['test'], fatal=True)
|
|
self.assertTrue(configs.write_all.called)
|
|
self.assertTrue(self.reinstall_paste_ini.called)
|
|
self.assertTrue(mock_update_image_location_policy.called)
|
|
self.assertTrue(self.remove_old_packages.called)
|
|
|
|
@patch.object(relations, 'update_image_location_policy')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_upgrade_charm_purge(self, configs,
|
|
mock_update_image_location_policy):
|
|
self.services.return_value = ['glance-api']
|
|
self.remove_old_packages.return_value = True
|
|
self.filter_installed_packages.return_value = ['test']
|
|
relations.upgrade_charm()
|
|
self.apt_install.assert_called_with(['test'], fatal=True)
|
|
self.assertTrue(configs.write_all.called)
|
|
self.reinstall_paste_ini.assert_called_once_with(force_reinstall=True)
|
|
self.assertTrue(mock_update_image_location_policy.called)
|
|
self.assertTrue(self.remove_old_packages.called)
|
|
self.service_restart.assert_called_once_with('glance-api')
|
|
|
|
def test_ha_relation_joined(self):
|
|
self.generate_ha_relation_data.return_value = {'rel_data': 'data'}
|
|
relations.ha_relation_joined(relation_id='rid:23')
|
|
self.relation_set.assert_called_once_with(
|
|
relation_id='rid:23', rel_data='data')
|
|
|
|
def test_ha_relation_changed_not_clustered(self):
|
|
self.relation_get.return_value = False
|
|
relations.ha_relation_changed()
|
|
self.juju_log.assert_called_with(
|
|
'ha_changed: hacluster subordinate is not fully clustered.'
|
|
)
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'keystone_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_configure_https_enable_with_identity_service(
|
|
self, configs, keystone_joined, _canonical_url):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['https']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = ['identity-service:0']
|
|
relations.configure_https()
|
|
self.check_call.assert_called_with(['a2ensite',
|
|
'openstack_https_frontend'])
|
|
self.service_reload.assert_called_with('apache2',
|
|
restart_on_failure=True)
|
|
keystone_joined.assert_called_with(relation_id='identity-service:0')
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'keystone_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_configure_https_disable_with_keystone_joined(
|
|
self, configs, keystone_joined, _canonical_url):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = ['identity-service:0']
|
|
relations.configure_https()
|
|
self.check_call.assert_called_with(['a2dissite',
|
|
'openstack_https_frontend'])
|
|
self.service_reload.assert_called_with('apache2',
|
|
restart_on_failure=True)
|
|
keystone_joined.assert_called_with(relation_id='identity-service:0')
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_configure_https_enable_with_image_service(
|
|
self, configs, image_service_joined, _canonical_url):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['https']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = ['image-service:0']
|
|
relations.configure_https()
|
|
self.check_call.assert_called_with(['a2ensite',
|
|
'openstack_https_frontend'])
|
|
self.service_reload.assert_called_with('apache2',
|
|
restart_on_failure=True)
|
|
image_service_joined.assert_called_with(relation_id='image-service:0')
|
|
|
|
@patch.object(relations, 'canonical_url')
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_configure_https_disable_with_image_service(
|
|
self, configs, image_service_joined, _canonical_url):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['']
|
|
configs.write = MagicMock()
|
|
self.relation_ids.return_value = ['image-service:0']
|
|
relations.configure_https()
|
|
self.check_call.assert_called_with(['a2dissite',
|
|
'openstack_https_frontend'])
|
|
self.service_reload.assert_called_with('apache2',
|
|
restart_on_failure=True)
|
|
image_service_joined.assert_called_with(relation_id='image-service:0')
|
|
|
|
def test_amqp_joined(self):
|
|
relations.amqp_joined()
|
|
self.relation_set.assert_called_with(
|
|
username='glance',
|
|
vhost='openstack')
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_amqp_changed_missing_relation_data(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = []
|
|
relations.amqp_changed()
|
|
self.assertTrue(self.juju_log.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_amqp_changed_relation_data(self, configs):
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['amqp']
|
|
configs.write = MagicMock()
|
|
relations.amqp_changed()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.assertFalse(self.juju_log.called)
|
|
|
|
@patch.object(relations, 'image_service_joined')
|
|
@patch.object(relations, 'keystone_joined')
|
|
def test_ha_relation_changed(self, ks_joined, image_joined):
|
|
self.relation_get.return_value = True
|
|
self.relation_ids.side_effect = [['identity:0'], ['image:1']]
|
|
relations.ha_relation_changed()
|
|
ks_joined.assert_called_with('identity:0')
|
|
image_joined.assert_called_with('image:1')
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_relation_broken(self, configs):
|
|
relations.relation_broken()
|
|
self.assertTrue(configs.write_all.called)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_cinder_volume_joined(self, configs):
|
|
self.filter_installed_packages.side_effect = lambda pkgs: pkgs
|
|
relations.cinder_volume_service_relation_joined()
|
|
self.assertTrue(configs.write_all.called)
|
|
self.apt_install.assert_called_with(
|
|
["python-cinderclient",
|
|
"python-os-brick",
|
|
"python-oslo.rootwrap"], fatal=True
|
|
)
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_cinder_volume_joined_rocky(self, configs):
|
|
self.filter_installed_packages.side_effect = lambda pkgs: pkgs
|
|
self.os_release.return_value = 'rocky'
|
|
relations.cinder_volume_service_relation_joined()
|
|
self.assertTrue(configs.write_all.called)
|
|
self.apt_install.assert_not_called()
|
|
|
|
@patch.object(relations, 'CONFIGS')
|
|
def test_storage_backend_changed(self, configs):
|
|
self.filter_installed_packages.side_effect = lambda pkgs: pkgs
|
|
configs.complete_contexts = MagicMock()
|
|
configs.complete_contexts.return_value = ['storage-backend']
|
|
configs.write = MagicMock()
|
|
relations.storage_backend_hook()
|
|
self.assertEqual([call('/etc/glance/glance-api.conf')],
|
|
configs.write.call_args_list)
|
|
self.apt_install.assert_called_with(
|
|
["python-cinderclient",
|
|
"python-os-brick",
|
|
"python-oslo.rootwrap"], fatal=True
|
|
)
|