68 lines
2.8 KiB
Plaintext
68 lines
2.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "277e0a78_83e5d6b8",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 2424
|
|
},
|
|
"writtenOn": "2024-03-22T00:40:42Z",
|
|
"side": 1,
|
|
"message": "recheck\n\nthe constraint was updated - https://github.com/openstack-charmers/zaza-openstack-tests/pull/1194",
|
|
"revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0f642968_7cb4996a",
|
|
"filename": "hooks/glance_contexts.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 379,
|
|
"author": {
|
|
"id": 14567
|
|
},
|
|
"writtenOn": "2024-03-22T15:07:21Z",
|
|
"side": 1,
|
|
"message": "there is no else to this IF. So, if cinder_volume_types is used, and there is no keystone_ctx to fill the other properties, then it will arrive at an error state that is causing the bug. Shouldn\u0027t it print an error message saying that there is a config problem or something so the error isn\u0027t triggered, and highlights that there is something to be fixed to the operator? If this is an error state that should not be ignored, we could raise an exception here and let the charm status be error so the operator fixes it.",
|
|
"range": {
|
|
"startLine": 379,
|
|
"startChar": 20,
|
|
"endLine": 379,
|
|
"endChar": 36
|
|
},
|
|
"revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1a0e1da6_2a07e7cb",
|
|
"filename": "hooks/glance_contexts.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 379,
|
|
"author": {
|
|
"id": 34275
|
|
},
|
|
"writtenOn": "2024-03-22T16:53:50Z",
|
|
"side": 1,
|
|
"message": "The thing is this code is executed several times as the relations between this charm and others are gradually being completed. Sometimes a partial version of this file (glance-api.conf) is generated first before the identity relation with keystone is established so it will lack the [keystone-authtoken] section and also these extra parameters. After the relation is established the file is generated again and in this case includes the extra fields (and the [kesytone-authtoken] section).\nThus, the if line is needed or otherwise the code will fail when the file is generated before the relation with keystone is complete.",
|
|
"parentUuid": "0f642968_7cb4996a",
|
|
"range": {
|
|
"startLine": 379,
|
|
"startChar": 20,
|
|
"endLine": 379,
|
|
"endChar": 36
|
|
},
|
|
"revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |