Update patch set 5

Patch Set 5:

(4 comments)

Patch-set: 5
CC: Gerrit User 20870 <20870@4a232e18-c5a9-48ee-94c0-e04e7cca6543>

091044dd0bb842bbce757aee2b5dbb7b97454ce5

@@ -0,0 +1,84 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "fd1cea26_b25e0e51",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 5
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 20870
+      },
+      "writtenOn": "2022-09-16T13:39:29Z",
+      "side": 1,
+      "message": "Just some minor comments for consideration.",
+      "revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e10fc58a_9c0c3fa0",
+        "filename": "requires.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 41,
+      "author": {
+        "id": 20870
+      },
+      "writtenOn": "2022-09-16T13:39:29Z",
+      "side": 1,
+      "message": "I know it existed before, but a dunderscore method get\u0027s name-mangled to the class (e.g. `_KeystoneAutoAccesors__accessor` in this case).  Is this what is wanted?",
+      "revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1693ce07_a24f217d",
+        "filename": "requires.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 71,
+      "author": {
+        "id": 20870
+      },
+      "writtenOn": "2022-09-16T13:39:29Z",
+      "side": 1,
+      "message": "It might be an nice opportunity to refactor this so that each str is on its own line?",
+      "range": {
+        "startLine": 58,
+        "startChar": 0,
+        "endLine": 71,
+        "endChar": 25
+      },
+      "revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "225a457e_d89b55af",
+        "filename": "requires.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 196,
+      "author": {
+        "id": 20870
+      },
+      "writtenOn": "2022-09-16T13:39:29Z",
+      "side": 1,
+      "message": "Tiny nit-pick.  This is equivalent to:\n\n    if all((reactive.is_flag_set(..), service_type, service_description)):\n        ...\n        \nAnd with a re-order, the reactive.is_flag_set() can be placed last to allow the short circuit to occur on simple flags?\n\ne.g.\n\n    if all((service_type, service_description, reactive.is_flag_set(..))):\n        ...\n\nHowever, if it clouds meaning, please ignore.",
+      "range": {
+        "startLine": 195,
+        "startChar": 1,
+        "endLine": 196,
+        "endChar": 63
+      },
+      "revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}