openstack
/
charm-interface-keystone
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(3 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 20870 \u003c20870@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_935\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 935 \u003c935@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_935\u003e replied on the change"}
This commit is contained in:
Gerrit User 935 2022-09-16 14:04:40 +00:00 committed by Gerrit Code Review
parent ef91f21759
commit 52821c9cdd
1 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
091044dd0bb842bbce757aee2b5dbb7b97454ce5
View File

@ -34,6 +34,24 @@
"revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a862acee_7c93bae3",
"filename": "requires.py",
"patchSetId": 5
},
"lineNbr": 41,
"author": {
"id": 935
},
"writtenOn": "2022-09-16T14:04:40Z",
"side": 1,
"message": "Its mainly all internal wiring but I\u0027ve dropped the dunderscore and renamed.",
"parentUuid": "e10fc58a_9c0c3fa0",
"revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -57,6 +75,30 @@
"revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a1fdb229_2c286170",
"filename": "requires.py",
"patchSetId": 5
},
"lineNbr": 71,
"author": {
"id": 935
},
"writtenOn": "2022-09-16T14:04:40Z",
"side": 1,
"message": "Done",
"parentUuid": "1693ce07_a24f217d",
"range": {
"startLine": 58,
"startChar": 0,
"endLine": 71,
"endChar": 25
},
"revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -79,6 +121,30 @@
},
"revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cc7b31de_3634f4c9",
"filename": "requires.py",
"patchSetId": 5
},
"lineNbr": 196,
"author": {
"id": 935
},
"writtenOn": "2022-09-16T14:04:40Z",
"side": 1,
"message": "A nice improvement - thanks!",
"parentUuid": "225a457e_d89b55af",
"range": {
"startLine": 195,
"startChar": 1,
"endLine": 196,
"endChar": 63
},
"revId": "091044dd0bb842bbce757aee2b5dbb7b97454ce5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}