openstack/charm-interface-keystone
Code Issues Proposed changes

Update patch set 3

Browse Source 
Patch Set 3:

(1 comment)

Patch-set: 3
CC: Gerrit User 33717 <33717@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 33717 2022-09-08 16:01:40 +00:00 committed by Gerrit Code Review
parent 4c50901931
commit 6e3b18ce4c
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
9ad5cade97e14b672ac859d34040353c3a40c7aa Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "4c6da810_643f1a1c",
"filename": "requires.py",
"patchSetId": 3
},
"lineNbr": 166,
"author": {
"id": 33717
},
"writtenOn": "2022-09-08T16:01:40Z",
"side": 1,
"message": "why are we iterating through all the relations instead of just going through the ones in `relation_info` as before ?\n\nIt seems as though this could be called multiple times - which is fine - except there doesn\u0027t appear to be any way to ensure that we aren\u0027t sending slightly different relation information.",
"revId": "9ad5cade97e14b672ac859d34040353c3a40c7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}