39 lines
1.3 KiB
Plaintext
39 lines
1.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c2e5150e_c5069668",
|
|
"filename": "requires.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 935
|
|
},
|
|
"writtenOn": "2022-09-07T11:31:19Z",
|
|
"side": 1,
|
|
"message": "I\u0027m not 100% happy with the lack of broken processing which requires a when_not joined handler - this seemed to break in my testing due to a lack of the object associated with the interface being passed to the handler.",
|
|
"revId": "23a75df0e3b2f88b91e54f01f64550f50af80448",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "231150f3_f84f0a58",
|
|
"filename": "requires.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 935
|
|
},
|
|
"writtenOn": "2022-09-15T08:59:00Z",
|
|
"side": 1,
|
|
"message": "After reviewing in more detail I think this is fine - update_flags will deal with clearing the connected flags once all units have disappeared so the rebase reliable reproduces what the original RelationBase class did behaviourally.",
|
|
"parentUuid": "c2e5150e_c5069668",
|
|
"revId": "23a75df0e3b2f88b91e54f01f64550f50af80448",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |