openstack/charm-interface-neutron-plugin-api-subordinate
Code Issues Proposed changes

Use unittest.mock instead of mock

Browse Source 
The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.

Note that https://github.com/openstack/charms.openstack is used during tests
and he need `mock`, unfortunatelly it doesn't declare `mock` in its
requirements so it retrieve mock from other charm project (cross dependency).
So we depend on charms.openstack first and when
Ib1ed5b598a52375e29e247db9ab4786df5b6d142 will be merged then CI
will pass without errors.

Depends-On: Ib1ed5b598a52375e29e247db9ab4786df5b6d142
Change-Id: I0550ad77a072d7edb083f24b260cbe034c8b9c75
This commit is contained in:
Hervé Beraud 2020-06-08 22:48:37 +02:00 committed by James Page
parent da16f31731
commit 33bcde1011
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test-requirements.txt
View File

@ -1,5 +1,4 @@
charms.reactive
flake8>=2.2.4
mock
stestr>=2.2.0
git+https://github.com/openstack/charms.openstack.git#egg=charms.openstack

2
unit_tests/test_provides.py
View File

@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import json
import mock
from unittest import mock
import charms_openstack.test_utils as test_utils