Update patch set 1
Patch Set 1: Code-Review+1 (2 comments) Patch-set: 1
This commit is contained in:
parent
87268f0321
commit
d6495bc6a7
50
75286e5117874e242ceb8af1a468772769c836c8
Normal file
50
75286e5117874e242ceb8af1a468772769c836c8
Normal file
@ -0,0 +1,50 @@
|
|||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "bf51134e_76a3b3b2",
|
||||||
|
"filename": "peers.py",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 34,
|
||||||
|
"author": {
|
||||||
|
"id": 24824
|
||||||
|
},
|
||||||
|
"writtenOn": "2020-07-20T10:00:49Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Should we depend on a deprecated key name here?\n\nMaybe we could use \u0027ingress-address\u0027 by now.",
|
||||||
|
"range": {
|
||||||
|
"startLine": 34,
|
||||||
|
"startChar": 34,
|
||||||
|
"endLine": 34,
|
||||||
|
"endChar": 49
|
||||||
|
},
|
||||||
|
"revId": "75286e5117874e242ceb8af1a468772769c836c8",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "bf51134e_d481d84f",
|
||||||
|
"filename": "peers.py",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 38,
|
||||||
|
"author": {
|
||||||
|
"id": 24824
|
||||||
|
},
|
||||||
|
"writtenOn": "2020-07-20T10:00:49Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "I left a comment here regarding the related Juju behavior: https://bugs.launchpad.net/charm-octavia/+bug/1849901/comments/8\n\nIt could be a bug or an undocumented feature in my view.",
|
||||||
|
"range": {
|
||||||
|
"startLine": 38,
|
||||||
|
"startChar": 12,
|
||||||
|
"endLine": 38,
|
||||||
|
"endChar": 50
|
||||||
|
},
|
||||||
|
"revId": "75286e5117874e242ceb8af1a468772769c836c8",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user