openstack
/
charm-keystone-saml-mellon
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(2 comments)

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 935 2019-10-23 12:45:08 +00:00 committed by Gerrit Code Review
parent 067e664a8a
commit 5f204763bb
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
778f16101c291d2d4fee91ade2159d10dc96cc8e Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "3fa7e38b_44b35cea",
"filename": "src/config.yaml",
"patchSetId": 1
},
"lineNbr": 68,
"author": {
"id": 935
},
"writtenOn": "2019-10-23T12:45:08Z",
"side": 1,
"message": "The quoting of keys above is not required and is inconsistent with the rest of the file - please remove!\n\nYou can also just use:\n\n default:\n\nwhich will mean the option will evaluate to Python None which is useful later.",
"revId": "778f16101c291d2d4fee91ade2159d10dc96cc8e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_a4c33038",
"filename": "src/templates/apache-mellon-location.conf",
"patchSetId": 1
},
"lineNbr": 6,
"author": {
"id": 935
},
"writtenOn": "2019-10-23T12:45:08Z",
"side": 1,
"message": "{% if options.idp_discovery_service_url -%}\n\nwill be sufficient with the minor tweak to how the default is handled.",
"revId": "778f16101c291d2d4fee91ade2159d10dc96cc8e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}