openstack
/
charm-keystone-saml-mellon
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
CC: Gerrit User 1131 <1131@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 21107 \u003c21107@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1131\u003e replied on the change"}
This commit is contained in:
Gerrit User 1131 2024-03-14 14:08:41 +00:00 committed by Gerrit Code Review
parent 1cc0f78cd4
commit e6d36edecc
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "47b3b052_813e55d5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1131
},
"writtenOn": "2024-03-14T14:08:41Z",
"side": 1,
"message": "I think if you added a bindep.txt (from master?) it might fix the py310 build failing with not finding pg_config\n\nbindep.txt:libpq-dev [platform:dpkg]",
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9fb3d632_6b8eb5bd",
"filename": "src/test-requirements.txt",
"patchSetId": 1
},
"lineNbr": 8,
"author": {
"id": 1131
},
"writtenOn": "2024-03-14T14:08:41Z",
"side": 1,
"message": "I know it semantically should be the same, but everywhere else we use 4.0.0",
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "41f68861_2408f600",
"filename": "tox.ini",
"patchSetId": 1
},
"lineNbr": 43,
"author": {
"id": 1131
},
"writtenOn": "2024-03-14T14:08:41Z",
"side": 1,
"message": "So do you not need this with the removal below?",
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}