Update patch set 2

Patch Set 2:

(3 comments)

Patch-set: 2
CC: Gerrit User 31836 <31836@4a232e18-c5a9-48ee-94c0-e04e7cca6543>

b96a48ca87d877ec0e28cd77c99b3a57319a1f8a

@@ -0,0 +1,55 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b588d785_922df6f0",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 2
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 31836
+      },
+      "writtenOn": "2022-10-27T14:44:07Z",
+      "side": 1,
+      "message": "Left some comments.",
+      "revId": "b96a48ca87d877ec0e28cd77c99b3a57319a1f8a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "2c089753_0d3a60d8",
+        "filename": "config.yaml",
+        "patchSetId": 2
+      },
+      "lineNbr": 111,
+      "author": {
+        "id": 31836
+      },
+      "writtenOn": "2022-10-27T14:44:07Z",
+      "side": 1,
+      "message": "I see on haproxy\u0027s docs that checks can be relatively smart, including an http-check connect and one or more http-check send plus expect statements.\n\nHaving two config properties one for the request and one for the expect prevents the use of these more complex check constructs from being configurable through the charm (or at least makes it a bit hacky, as perhaps one of the two could be used to set a multi-line value and get away with it?).\n\nSo how about having an single haproxy-check-config property? As an example, its default could be what\u0027s on the code at the time of writting this comment: \"http-check send meth GET uri /healthcheck\\nhttp-check expect status 200\".",
+      "revId": "b96a48ca87d877ec0e28cd77c99b3a57319a1f8a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "f7993932_a08e06ea",
+        "filename": "config.yaml",
+        "patchSetId": 2
+      },
+      "lineNbr": 111,
+      "author": {
+        "id": 31836
+      },
+      "writtenOn": "2022-10-27T14:44:07Z",
+      "side": 1,
+      "message": "Given that there are several other checks supported by haproxy (I see mysql, psql, external, ldap, etc.), what about changing the name of the property to \"haproxy-http-check-expected\"?",
+      "revId": "b96a48ca87d877ec0e28cd77c99b3a57319a1f8a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}