Update patch set 3
Patch Set 3: (4 comments) Patch-set: 3 Attention: {"person_ident":"Gerrit User 31836 \u003c31836@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33536\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 33536 \u003c33536@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33536\u003e replied on the change"}
This commit is contained in:
parent
59e5f1f663
commit
dd5adca2ee
21
b2d379e6d95c61e9fb167067bbc7072dddc5d4f2
Normal file
21
b2d379e6d95c61e9fb167067bbc7072dddc5d4f2
Normal file
@ -0,0 +1,21 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "910bf227_33eb0bf4",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 33536
|
||||
},
|
||||
"writtenOn": "2022-10-31T13:23:58Z",
|
||||
"side": 1,
|
||||
"message": "Thanks Facundo for your review.\n\nI\u0027ve changed this patch to have a single configuration named \"haproxy-check-http-config\" as you pointed in the review.\n\nCould you also review the change on charm-layer-openstack that is dependent on this change?\n\nhttps://review.opendev.org/c/openstack/charm-layer-openstack/+/862752\n\nThanks",
|
||||
"revId": "b2d379e6d95c61e9fb167067bbc7072dddc5d4f2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
@ -17,6 +17,24 @@
|
||||
"revId": "b96a48ca87d877ec0e28cd77c99b3a57319a1f8a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "5c43ce06_5b7ce640",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 33536
|
||||
},
|
||||
"writtenOn": "2022-10-31T13:23:58Z",
|
||||
"side": 1,
|
||||
"message": "Ack",
|
||||
"parentUuid": "b588d785_922df6f0",
|
||||
"revId": "b96a48ca87d877ec0e28cd77c99b3a57319a1f8a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@ -50,6 +68,42 @@
|
||||
"message": "Given that there are several other checks supported by haproxy (I see mysql, psql, external, ldap, etc.), what about changing the name of the property to \"haproxy-http-check-expected\"?",
|
||||
"revId": "b96a48ca87d877ec0e28cd77c99b3a57319a1f8a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e0a239a1_8bccaccb",
|
||||
"filename": "config.yaml",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 111,
|
||||
"author": {
|
||||
"id": 33536
|
||||
},
|
||||
"writtenOn": "2022-10-31T13:23:58Z",
|
||||
"side": 1,
|
||||
"message": "Ack",
|
||||
"parentUuid": "2c089753_0d3a60d8",
|
||||
"revId": "b96a48ca87d877ec0e28cd77c99b3a57319a1f8a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "30413bec_d4d57135",
|
||||
"filename": "config.yaml",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 111,
|
||||
"author": {
|
||||
"id": 33536
|
||||
},
|
||||
"writtenOn": "2022-10-31T13:23:58Z",
|
||||
"side": 1,
|
||||
"message": "Ack",
|
||||
"parentUuid": "f7993932_a08e06ea",
|
||||
"revId": "b96a48ca87d877ec0e28cd77c99b3a57319a1f8a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user