openstack
/
charm-layer-openstack
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 12549 <12549@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 33536 \u003c33536@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_12549\u003e replied on the change"}
This commit is contained in:
Gerrit User 12549 2022-11-08 11:47:44 +00:00 committed by Gerrit Code Review
parent 5c845dde63
commit f8899ad807
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
4f2f99ffd415c53952d235d2f05f6df5c63364e3
View File

@ -16,6 +16,23 @@
"message": "Looks good!",
"revId": "4f2f99ffd415c53952d235d2f05f6df5c63364e3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9de57304_d86160b6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 12549
},
"writtenOn": "2022-11-08T11:47:44Z",
"side": 1,
"message": "I think picking up the healthcheck config from a charm config option exposed to the enduser is probably the wrong approach as the charm should know the correct way to acertain the health of the service. See my comment on https://review.opendev.org/c/openstack/charm-layer-openstack-api/+/862750 for more details",
"revId": "4f2f99ffd415c53952d235d2f05f6df5c63364e3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}