From 310647c2bd3010f0ae9096e396d21402d20a95bf Mon Sep 17 00:00:00 2001 From: Gustavo Sanchez Date: Fri, 20 Aug 2021 10:41:53 -0400 Subject: [PATCH] Fixes flacky unit test wih py36 When running TestManilaCharm.test_install() with py36 sometimes test passes and sometimes throws and error while mocking methods. Seems to be an async race problem mocking a super method first. This was solved by avoiding mocking super method first. Closes-Bug: #1940552 Change-Id: Iac55321599b4866784a0631639a93fc828780647 --- unit_tests/test_lib_charm_openstack_manila.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unit_tests/test_lib_charm_openstack_manila.py b/unit_tests/test_lib_charm_openstack_manila.py index 073a798..5d442de 100644 --- a/unit_tests/test_lib_charm_openstack_manila.py +++ b/unit_tests/test_lib_charm_openstack_manila.py @@ -95,10 +95,10 @@ class TestManilaCharm(Helper): return c def test_install(self): - self.patch('builtins.super', 'super') self.patch("subprocess.check_call", name="check_call") self.patch("charms_openstack.charm.OpenStackCharm.assess_status", name="assess_status") + self.patch('builtins.super', name='super') c = manila.ManilaCharm() c.install() self.check_call.assert_called_once_with(["mkdir", "-p", "/etc/nova"])