openstack
/
charm-mysql-innodb-cluster
Code Issues Proposed changes

Merge "mysqldump: add --set-gtid-purged=COMMENTED to mysqldump command"

This commit is contained in:
Zuul 2022-11-07 12:00:20 +00:00 committed by Gerrit Code Review
parent 85a3deee22 82ebc349fa
commit 0a0418e327
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/charm/openstack/mysql_innodb_cluster.py
View File

@ -1805,7 +1805,8 @@ class MySQLInnoDBClusterCharm(
bucmd = ["/usr/bin/mysqldump", "-u", _user,
"--triggers", "--routines", "--events",
"--ignore-table=mysql.event"]
"--ignore-table=mysql.event",
"--set-gtid-purged=COMMENTED"]
if databases is not None:
_filename = os.path.join(
backup_dir,

3
unit_tests/test_lib_charm_openstack_mysql_innodb_cluster.py
View File

@ -1502,6 +1502,7 @@ class TestMySQLInnoDBClusterCharm(test_utils.PatchHelper):
mock.call(
["/usr/bin/mysqldump", "-u", "root", "--triggers",
"--routines", "--events", "--ignore-table=mysql.event",
"--set-gtid-purged=COMMENTED",
"--result-file", _filename, "--all-databases"]),
mock.call(["/usr/bin/gzip", _filename])]
@ -1517,6 +1518,7 @@ class TestMySQLInnoDBClusterCharm(test_utils.PatchHelper):
mock.call(
["/usr/bin/mysqldump", "-u", "root", "-ppass", "--triggers",
"--routines", "--events", "--ignore-table=mysql.event",
"--set-gtid-purged=COMMENTED",
"--result-file", _filename, "--databases", _dbs]),
mock.call(["/usr/bin/gzip", _filename])]
self.assertEqual(midbc.mysqldump(_path, databases=_dbs),
@ -1531,6 +1533,7 @@ class TestMySQLInnoDBClusterCharm(test_utils.PatchHelper):
mock.call(
["/usr/bin/mysqldump", "-u", "root", "-ppass", "--triggers",
"--routines", "--events", "--ignore-table=mysql.event",
"--set-gtid-purged=COMMENTED",
"--result-file", _filename, "--databases"].extend(
_dbs.split(","))),
mock.call(["/usr/bin/gzip", _filename])]