Update patch set 3

Patch Set 3: Code-Review-2

(1 comment)

Patch-set: 3
Label: Code-Review=-2, 67ce2c012dd4cfe2c49c6f42c0748ac1450aee14

fbc3965e0a130d4099b8be28b8dd62c6b8db329d

@@ -33,6 +33,23 @@
       "message": "I actually think this review should be abandoned, on reflection.  We\u0027re essentially trying to recover from a situation where a unit ran out of disk space and corrupted the unit.  In this scenario, we probably ought to be discarding the unit and starting again with a new unit as it\u0027s not clear what else on the unit is broken.\n\nAlternatively, add an action to rerun the bootstrap process (using bootstrap_mysqlrouter() method in the src/lib/charm/openstack/mysql_router.py file), would guarantee getting the \u0027latest\u0027 best config file.\n\nAdding a backup file just sounds like additional \u0027caching\u0027 for not much extra benefit.  Maintaining the backup file is more work for the charm and more complexity.\n\nIt\u0027s also possible to manually force the unit to re-write the bootstrap by clearing the \"charm.mysqlrouter.bootstrapped\" flag, which would then re-run the bootstrap process.",
       "revId": "fbc3965e0a130d4099b8be28b8dd62c6b8db329d",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "85332e89_e81a8e67",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 3
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 2424
+      },
+      "writtenOn": "2023-06-02T16:50:59Z",
+      "side": 1,
+      "message": "Considering the different arguments expressed in this review, I will mark this patch with a CR-2 since this patch in it\u0027s current form won\u0027t be merged, and -1 doesn\u0027t reflect that.\n\nSeyeong, if you think there are aspects that we aren\u0027t considering or weighting properly, please let us know.",
+      "revId": "fbc3965e0a130d4099b8be28b8dd62c6b8db329d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }