Update patch set 4

Patch Set 4:

(1 comment)

Patch-set: 4
CC: Gerrit User 6737 <6737@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 6737 2021-09-06 09:01:49 +00:00 committed by Gerrit Code Review
parent d296c00017
commit 97ef0e7f0f
1 changed files with 27 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "6d41d89f_3cac9c5c",
"filename": "hooks/neutron_api_context.py",
"patchSetId": 4
},
"lineNbr": 299,
"author": {
"id": 6737
},
"writtenOn": "2021-09-06T09:01:49Z",
"side": 1,
"message": "I wonder if a \"softer\" message wounldn\u0027t be better here. If an environment is upgraded from e.g. U to V and this option is left on the fwaas will be disabled/removed but everything else will continue to work as normal. Also the release notes have an entry to explain the fwaas resources should be deleted where possible prior to upgraded. So Im thinking maybe this should be a WARN msg like \"the fwaas option is true but will be ignored and disabled for releases outside of Stein to Ussuri.\"",
"range": {
"startLine": 299,
"startChar": 0,
"endLine": 299,
"endChar": 22
},
"revId": "0cfaca49b0df530b31fa4f81f44e3c761cd4bafc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}