Merge "Disable vrrp healthchecks by default"

config.yaml

@@ -376,12 +376,18 @@ options:
       is used with neutron. This option is ignored for Train+ OpenStack.
   keepalived-healthcheck-interval:
     type: int
-    default: 30
+    default: 0
     description: |
-      By default all HA routers will check their external network gateway
-      by sending a ping and if that fails they trigger a vrrp transition. This
-      option defines how frequently this check is performed. Setting this value
-      to 0 will disable the healthchecks.
+      Specifies the frequency (in seconds) at which HA routers will check
+      their external network gateway by performing an ICMP ping between the
+      virtual routers. When the ping check fails, this will trigger the HA
+      routers to failover to another node. A value of 0 will disable this
+      check. This setting only applies when using l3ha and dvr_snat.
+      .
+      WARNING: Enabling the health checks should be done with caution as it
+      may lead to rapid failovers of HA routers. ICMP pings are low priority
+      and may be dropped or take longer than the 1 second afforded by neutron,
+      which leads to routers failing over to other nodes.
   enable-auto-restarts:
     type: boolean
     default: True

unit_tests/test_neutron_contexts.py

@@ -302,7 +302,7 @@ class TestNeutronGatewayContext(CharmTestCase):
             'nfg_log_output_base': None,
             'nfg_log_rate_limit': None,
             'ovsdb_timeout': 60,
-            'keepalived_healthcheck_interval': 30,
+            'keepalived_healthcheck_interval': 0,
         })
 
     @patch('os.environ.get')