The bundle disco-stein was in the dev bundles because
a bug with the Python 3.7 syntax prevented the success of
the deployment of HA clusters. This bug is fixed, we can
reintegrate disco-stein in the gate bundles.
Other small additions:
- removing sitepackages in tox.ini to avoid test env pollution
- skip_missing_interpreters in tox.ini set to False to avoid false
positives by skipping missing interpreters.
LP Related-Bug: #1823718
Change-Id: I268df41f6f775560580b49fa60f717ba8da88def
This patchset removes the load-time mocking necessary due to load-time
function calls in 'constants'. The constants are changed to run-time
functions and and the lazy feature of restart_on_change is used, and the
harden disable for unit testing is switched on when needed.
Change-Id: I73e719ed082a7c8f9c477fd82094532bdbb8029b
Ensure that EOL releases are removed from metadata
and tests, and that the current dev release is enabled
in metadata. Dev release tests are enabled separately
because of chickens and eggs.
Change-Id: If39fc59a251290aa34b11180616ed60768537f92
Revert "Stop using veth pairs to connect qdhcp ns"
Reverting as this change causes existing qdhcp namespaces to become
inaccessible.
This reverts commit bbc20dbe49.
Change-Id: I91ec8b34bd531e48d00c48512a43921f97b6d9a2
Sync charm-helpers and use "rabbit_use_ssl" for ocata
Ensure "rabbit_use_ssl" is specified in the [oslo_messaging_rabbit]
config section instead of "ssl" for Ocata, since "ssl" was not yet
introduced.
Change-Id: I5c3776bf31603e93ba37e9de5a8516d1897f1935
Closes-Bug: #1838696
This is a mechanically generated patch to ensure unit testing is in place
for all of the Tested Runtimes for Train.
See the Train python3-updates goal document for details:
https://governance.openstack.org/tc/goals/train/python3-updates.html
Note that python35-charm-jobs is retained since this charm is supported
on Xenial.
Change-Id: I72638af28accb42482caf43e78d0418f1b722e89
Story: #2005924
Task: #34228
Modify paths to ensure that charms' charmhelpers is first
The pre-patch version of unit-testing tested the git-repo version of
charm-helpers instead of the version that was synced to the charm.
The git-repo version of charmhelpers is pip installed to obtain the
testing part of charm-helpers, for the unit tests. Whilst this is a bug
(really), it was compounded in that - due to how the paths worked - the
unit tests' git version of charm-helpers was in the path first, and thus
all unit tests were performed using that version of charm-helpers, and
not the version actually synced into the charm. This has led to all
sorts of 'odd' double mocking of config in the tests as there are
potentially two copies of charm-helpers (as was the case for py27). A
further commit will undo that madness.
This patchset moves the charm synced version of charm-helpers earlier
into the path so it gets picked first when the modules are loaded.
Change-Id: Iff0566c52a283ff0cd2fc7707d981d8c47f3e6b2
Enable support for configuration of FWaaS v2 firewall group
logging.
Configuration options mirror those for neutron-openvswitch
for security group logging.
This feature is currently only enabled for FWaaS v2 at Stein
for the charms (but is supported back to Queens in Neutron).
Change-Id: If1b332eb0f581e9acba111f79ba578a0b7081dd2
Partial-Bug: 1831972
veth pairs are currently being used to connect the qdhcp namespace
to the underlying bridge. This behaviour appears to only be needed
for old kernels with limited namespaces support (pre trusty).
Change-Id: I3b090f07c995cbf375dcc1dfdbadf0d7f10ec78e
Closes-Bug: #1832021
When an isolated provider network with no virtual routers metadata
access occurs in the qdhcp netns.
Without the force_metadata option in dhcp_agent.ini ns-metadata-proxy
is not enabled. ns-metdata-proxy sits in the ip netns and proxies
requests from 169.254.169.254 to the nova-api-metadata service
outside the netns.
This change adds the force_metadata option when
enable-isolated-metadata = True.
Related to LP Bug #1831935
Change-Id: I4fde7882be69772f168a1a1a201022bf9cf3cd06
Two generic contexts to handle nova vendor metadata have
been implemented in charm-helpers. So, replace the existing
one here in order to simplify and unify the implementation
across all charms that handle vendor metadata.
Change-Id: I2a802c763f2f4403a6dfb17575aa742ca8072e96
Related-Bug: #1777714
Ensure we only try to set sysctls outside of a container
THe sysctls are not available inside of a container, so we
should not set them.
Change-Id: I93e1052958a8c8fb44c0589caf7cb5d6a6019ab8
Closes-Bug: #1829047
If you want to have vrrp watch the external networking interface
today, the option ha_vrrp_health_check_interval [1] detects a failure
it re-triggers the transitional change - which works if the external
physical interface fails because the ping will fail.
In fact, we've tried to enable it before [2], but then we had to
revert it [3] due to instability issues [4] in previous releases of
OpenStack. Maybe the previous instability issue [4] was caused by
another keepalived issue mentioned in the comment [5], now I have
tested this option again, it works.
This is how neutron allows monitoring southbound network today, so
I would suggest we add this capability into the charm again.
[1] https://docs.openstack.org/ocata/networking-guide/ \
deploy-ovs-ha-vrrp.html#keepalived-vrrp-health-check
[2] https://review.opendev.org/#/c/601533/
[3] https://review.opendev.org/#/c/603347/
[4] https://bugs.launchpad.net/neutron/+bug/1793102
[5] https://bugs.launchpad.net/neutron/+bug/1793102/comments/5
Change-Id: If2947e7640545cb9a48215afb9b2439fdc33c645
Closes-Bug: 1825966
Ensure that EOL releases are removed from metadata
and tests, and that the current dev release is enabled
in metadata. Dev release tests are enabled separately
because of chickens and eggs.
Change-Id: I47ad064d1a183040d51b96ce474fb03e52e04588
This technique was borrowed from the tox "cover" environment in
openstack/nova's tox.ini. This leverages the fact that stestr lets
you override the python executable via the PYTHON environment
variable. Doing this allows us to easily generate coverage for our
unit tests.
An important caveat is that this does not provide any coverage for
tests via zaza, amulet, etc. It is purely focused on the unit tests.
Note that this replaces the previous .coveragerc; coverage
configuration is instead pulled from tox.ini.
Change-Id: Ibb6306a45f35c1a22794e1a019bb357831442df4
When clouds have a large number of hosts, the default size of the ARP
cache is too small. The cache can overflow, which means that the
system has no way to reach some ip addresses.
Setting the threshold limits higher addresses the situation, in a
reasonably safe way (the maximum impact is 5MB or so of additional RAM
used). Docs on ARP at http://man7.org/linux/man-pages/man7/arp.7.html,
and more discussion of the issue in the bug.
Change-Id: I701141784224f5f870f6da73a24bed8015694409
Closes-Bug: 1780348
The stein version of python-oslo.messaging (9.0.0+) has removed
the following config options from the [oslo_messaging_rabbit]
section:
rabbit_host, rabbit_port, rabbit_hosts, rabbit_userid,
rabbit_password, rabbit_virtual_host rabbit_max_retries, and
rabbit_durable_queues.
The above change requires a sync from charm-helpers.
Additionally the transport_url directive has been moved to the
[DEFAULT] section.
These have been deprecated since Ocata, therefore this change
will be provided to pre-Stein templates in order to drop
deprecation warnings.
See release notes at:
https://docs.openstack.org/releasenotes/oslo.messaging/index.html
test_300_neutron_config is also removed in this change as amulet
tests no longer need to confirm config file settings.
Change-Id: I4b95c3ff4a37a09e7df5fb5cb6331dc3a46c0095
Closes-Bug: #1817672
Using the new version of the sync tool which removes the charmhelpers
directory before syncing, run charm helpers sync to find any unexpected
missing dependencies.
Change-Id: I8a01637e77fa4e76ba5144e1c28a3fb98d339084
For guest operating systems that rely on nova metadata rather than dhcp
offers for host dns domain settings it is necessary to set dhcp_domain
in the nova.conf.
Change-Id: If7de988ddcd8817d02b261bea601d6922275890c
Partial-Bug: #1805645
Zuul
Dmitrii Shcherbakov
Camille Rodriguez
Alex Kavanagh
Chris MacNaughton
Liam Young
Corey Bryant
James Page
David Ames
Rodrigo Barbieri
Chris MacNaughton
Zhang Hua
OpenDev Sysadmins
Frode Nordahl
Edward Hope-Morley
Pete Vander Giessen
Paul Goins
Ryan Beisner
caoyuan
Zuul
Junien Fridrick
melissaml