Use unittest.mock instead of mock

The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.

Note that https://github.com/openstack/charms.openstack is used during tests
and he need `mock`, unfortunatelly it doesn't declare `mock` in its
requirements so it retrieve mock from other charm project (cross dependency).
So we depend on charms.openstack first and when
Ib1ed5b598a52375e29e247db9ab4786df5b6d142 will be merged then CI
will pass without errors.

Depends-On: Ib1ed5b598a52375e29e247db9ab4786df5b6d142
Change-Id: Id925078c5c04c2f89a570bdf7171c666839f9e40
This commit is contained in:
Hervé Beraud
2020-06-08 23:04:01 +02:00
committed by James Page
parent 1e69076af6
commit 71bc319326
9 changed files with 7 additions and 14 deletions

View File

@@ -1,5 +1,4 @@
- project:
templates:
- python35-charm-jobs
- openstack-python3-ussuri-jobs
- openstack-cover-jobs

View File

@@ -13,11 +13,6 @@ setuptools<50.0.0 # https://github.com/pypa/setuptools/commit/04e3df22df840c6bb
requests>=2.18.4
# Newer mock seems to have some syntax which is newer than python3.5 (e.g.
# f'{something}'
mock>=1.2,<4.0.0; python_version < '3.6'
mock>=1.2; python_version >= '3.6'
stestr>=2.2.0
# Dependency of stestr. Workaround for

View File

@@ -14,7 +14,7 @@
import os
import sys
import mock
from unittest import mock
# python-apt is not installed as part of test-requirements but is imported by
# some charmhelpers modules so create a fake import.

View File

@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import mock
from unittest import mock
from unit_tests.test_utils import (
CharmTestCase,

View File

@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
from mock import patch
from unittest.mock import patch
from unit_tests.test_utils import CharmTestCase
import charmhelpers.core.unitdata

View File

@@ -13,7 +13,7 @@
# limitations under the License.
import json
import mock
from unittest import mock
import hooks.nova_cc_context as context

View File

@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
from mock import MagicMock, patch, call
from unittest.mock import MagicMock, patch, call
import os
import tempfile

View File

@@ -13,10 +13,9 @@
# limitations under the License.
from collections import OrderedDict
from mock import patch, MagicMock, call
import subprocess
import charmhelpers.core.unitdata
from unittest.mock import patch, MagicMock, call
from unit_tests.test_utils import (
CharmTestCase,

View File

@@ -21,7 +21,7 @@ import unittest
import yaml
from contextlib import contextmanager
from mock import patch, MagicMock
from unittest.mock import patch, MagicMock
def load_config():