openstack/charm-nova-cloud-controller
Code Issues Proposed changes

Test resolvability of short names

Browse Source 
There is no guarantee short hostnames will be DNS resolvable. Test
first before adding to the compute hosts list.

Change-Id: Ieddf098f97ebdfdf9074016998308e2887532d25
This commit is contained in:
David Ames
2016-10-21 11:13:24 -07:00
parent 71e74cd0b0
commit d5d2e5064e
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
hooks/charmhelpers/contrib/network/ip.py
View File

@@ -424,7 +424,11 @@ def ns_query(address):
else:
return None
answers = dns.resolver.query(address, rtype)
try:
answers = dns.resolver.query(address, rtype)
except dns.resolver.NXDOMAIN as e:
return None
if answers:
return str(answers[0])
return None