9c12812735
Some major changes: * the charm has been rebased (from a Python perspective) to be rooted in the charm directory. This is a single root. * Imports have been changed so that the don't add lots of imports to the namespace of the module doing the import. * The code that used to run at module import time has been made lazy such that it only has to run if the relevant functions are called. This includes restart_on_change parameters, the harden function and the parameters to the guard_map. Appropriate changes will be submitted to charm-helpers. * Several tests had to be re-written as (incorrect) mocking meant that text fixtures didn't actually match what the code was doing. Thus, the tests were meaningless. * This has had a net positive impact on the unit tests wrt to importing modules and mocking. Change-Id: Id07d9d1caaa9b29453a63c2e49ba831071e9457f
70 lines
2.5 KiB
Python
70 lines
2.5 KiB
Python
# Copyright 2014-2015 Canonical Limited.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import os
|
|
from subprocess import check_output, CalledProcessError, STDOUT
|
|
from charmhelpers.fetch import (
|
|
BaseFetchHandler,
|
|
UnhandledSource,
|
|
filter_installed_packages,
|
|
install,
|
|
)
|
|
|
|
if filter_installed_packages(['git']) != []:
|
|
install(['git'])
|
|
if filter_installed_packages(['git']) != []:
|
|
raise NotImplementedError('Unable to install git')
|
|
|
|
|
|
class GitUrlFetchHandler(BaseFetchHandler):
|
|
"""Handler for git branches via generic and github URLs."""
|
|
|
|
def can_handle(self, source):
|
|
url_parts = self.parse_url(source)
|
|
# TODO (mattyw) no support for ssh git@ yet
|
|
if url_parts.scheme not in ('http', 'https', 'git', ''):
|
|
return False
|
|
elif not url_parts.scheme:
|
|
return os.path.exists(os.path.join(source, '.git'))
|
|
else:
|
|
return True
|
|
|
|
def clone(self, source, dest, branch="master", depth=None):
|
|
if not self.can_handle(source):
|
|
raise UnhandledSource("Cannot handle {}".format(source))
|
|
|
|
if os.path.exists(dest):
|
|
cmd = ['git', '-C', dest, 'pull', source, branch]
|
|
else:
|
|
cmd = ['git', 'clone', source, dest, '--branch', branch]
|
|
if depth:
|
|
cmd.extend(['--depth', depth])
|
|
check_output(cmd, stderr=STDOUT)
|
|
|
|
def install(self, source, branch="master", dest=None, depth=None):
|
|
url_parts = self.parse_url(source)
|
|
branch_name = url_parts.path.strip("/").split("/")[-1]
|
|
if dest:
|
|
dest_dir = os.path.join(dest, branch_name)
|
|
else:
|
|
dest_dir = os.path.join(os.environ.get('CHARM_DIR'), "fetched",
|
|
branch_name)
|
|
try:
|
|
self.clone(source, dest_dir, branch, depth)
|
|
except CalledProcessError as e:
|
|
raise UnhandledSource(e)
|
|
except OSError as e:
|
|
raise UnhandledSource(e.strerror)
|
|
return dest_dir
|