Update patch set 3
Patch Set 3: (2 comments) Patch-set: 3 Attention: {"person_ident":"Gerrit User 10058 \u003c10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10058\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 14567 \u003c14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10058\u003e replied on the change"}
This commit is contained in:
parent
bc45d8cc22
commit
116a362ecd
@ -51,6 +51,47 @@
|
||||
"parentUuid": "38e57b97_84f8da0e",
|
||||
"revId": "2ef454c7bd556f3a425b40792899d7dc1f76eed5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "40443734_28f68efa",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 10058
|
||||
},
|
||||
"writtenOn": "2024-04-23T14:52:10Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for the explanation. I believe that we can continue with your current approach given the added complexity of adding a sysconfig parameter in the ovn charms.",
|
||||
"parentUuid": "c398571b_5db2d132",
|
||||
"revId": "2ef454c7bd556f3a425b40792899d7dc1f76eed5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "29ca6a6f_5cd2c66d",
|
||||
"filename": "hooks/nova_compute_hooks.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 352,
|
||||
"author": {
|
||||
"id": 10058
|
||||
},
|
||||
"writtenOn": "2024-04-23T14:52:10Z",
|
||||
"side": 1,
|
||||
"message": "Can you leave a comment explaining that this function will persist the changes?",
|
||||
"range": {
|
||||
"startLine": 352,
|
||||
"startChar": 12,
|
||||
"endLine": 352,
|
||||
"endChar": 36
|
||||
},
|
||||
"revId": "2ef454c7bd556f3a425b40792899d7dc1f76eed5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user