Replace Underscores in Configs with Dashes

A few config options, namely: skip_cpu_compare_at_startup,
skip_cpu_compare_on_dest, nagios_context, and nagios_servicegroups, use
underscores instead of following the convention of using dashes. This
commit fixes skip_cpu_compare_* to skip-cpu-compare-* to ensure
conformance with the precedent since they are new options to the charm
and can be modified safely.

Change-Id: Iea19544915ec9a609333d0d182935e6758a7b2b0
Signed-off-by: Bryan Fraschetti <bryan.fraschetti@canonical.com>

config.yaml

@@ -183,7 +183,7 @@ options:
         homedir - user's home directory
         username - username
       .
-  skip_cpu_compare_at_startup:
+  skip-cpu-compare-at-startup:
     type: boolean
     default: False
     description: |
@@ -199,7 +199,7 @@ options:
       .
       # NOTE: This can be removed when https://launchpad.net/nova/+bug/2039803
       # is fixed
-  skip_cpu_compare_on_dest:
+  skip-cpu-compare-on-dest:
     type: boolean
     default: False
     description: |

hooks/nova_compute_context.py

@@ -258,9 +258,9 @@ class NovaComputeLibvirtContext(context.OSContextGenerator):
             ctxt['live_migration_permit_auto_converge'] = \
                 config('live-migration-permit-auto-converge')
             ctxt['skip_cpu_compare_at_startup'] = \
-                config('skip_cpu_compare_at_startup')
+                config('skip-cpu-compare-at-startup')
             ctxt['skip_cpu_compare_on_dest'] = \
-                config('skip_cpu_compare_on_dest')
+                config('skip-cpu-compare-on-dest')
 
         if config('instances-path') is not None:
             ctxt['instances_path'] = config('instances-path')

unit_tests/test_nova_compute_contexts.py

@@ -671,8 +671,8 @@ class NovaComputeContextTests(CharmTestCase):
         self.kv.return_value = FakeUnitdata(**{'host_uuid': self.host_uuid})
         self.lsb_release.return_value = {'DISTRIB_CODENAME': 'lucid'}
         self.test_config.set('enable-live-migration', True)
-        self.test_config.set('skip_cpu_compare_at_startup', True)
-        self.test_config.set('skip_cpu_compare_on_dest', True)
+        self.test_config.set('skip-cpu-compare-at-startup', True)
+        self.test_config.set('skip-cpu-compare-on-dest', True)
         libvirt = context.NovaComputeLibvirtContext()
 
         self.assertEqual(