diff --git a/2ef454c7bd556f3a425b40792899d7dc1f76eed5 b/2ef454c7bd556f3a425b40792899d7dc1f76eed5 index a3238d0e..0db78a25 100644 --- a/2ef454c7bd556f3a425b40792899d7dc1f76eed5 +++ b/2ef454c7bd556f3a425b40792899d7dc1f76eed5 @@ -16,6 +16,23 @@ "message": "charm-recheck", "revId": "2ef454c7bd556f3a425b40792899d7dc1f76eed5", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "38e57b97_84f8da0e", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 3 + }, + "lineNbr": 0, + "author": { + "id": 10058 + }, + "writtenOn": "2024-04-22T23:45:39Z", + "side": 1, + "message": "This approach does not look correct to me. The bottom line is that we are adding a fix to charm-ovn-xxx on charm-nova-compute. This will be hard to control once we have more of this kind of cross-charm fixes.\nThe second thing I see here is that we are loading a module to nf_conntrack, while there are many other possible values to `sysctl` and we don\u0027t have how to cover all modules or other dependencies from those.\n\nIMO, the responsibility to load and set the module and sysconfig values should be to the networking layer, which should load all sysconfigs and modules it needs. That should be done on install time, not during config-changed.\n\nBTW, charm-neutron-gateway has a fix[1] in those lines, though it also does the module loading during config-changed.\n\n[1] https://review.opendev.org/c/openstack/charm-neutron-gateway/+/738116/4/hooks/neutron_hooks.py#b140", + "revId": "2ef454c7bd556f3a425b40792899d7dc1f76eed5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file