Files
charm-openstack-dashboard/unit_tests/test_actions_openstack_upgrade.py
Hervé Beraud 9da66b4cc5 Use unittest.mock instead of mock
The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.

Note that https://github.com/openstack/charms.openstack is used during tests
and he need `mock`, unfortunatelly it doesn't declare `mock` in its
requirements so it retrieve mock from other charm project (cross dependency).
So we depend on charms.openstack first and when
Ib1ed5b598a52375e29e247db9ab4786df5b6d142 will be merged then CI
will pass without errors.

Depends-On: Ib1ed5b598a52375e29e247db9ab4786df5b6d142
Change-Id: I718a003c5f07e390457bc39e69871c7ecb533e7b
2021-12-15 14:33:48 +00:00

75 lines
2.5 KiB
Python

# Copyright 2016 Canonical Ltd
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import os
import sys
from unittest.mock import patch, MagicMock
os.environ['JUJU_UNIT_NAME'] = 'openstack-dashboard'
# python-apt is not installed as part of test-requirements but is imported by
# some charmhelpers modules so create a fake import.
mock_apt = MagicMock()
sys.modules['apt'] = mock_apt
mock_apt.apt_pkg = MagicMock()
with patch('charmhelpers.contrib.hardening.harden.harden') as mock_dec:
mock_dec.side_effect = (lambda *dargs, **dkwargs: lambda f:
lambda *args, **kwargs: f(*args, **kwargs))
with patch('hooks.horizon_utils.register_configs') as register_configs:
import actions.openstack_upgrade as openstack_upgrade
from unit_tests.test_utils import CharmTestCase
TO_PATCH = [
'resolve_CONFIGS',
'do_action_openstack_upgrade',
'do_openstack_upgrade',
'config_changed',
]
class TestHorizonUpgradeActions(CharmTestCase):
def setUp(self):
super(TestHorizonUpgradeActions, self).setUp(openstack_upgrade,
TO_PATCH)
def test_openstack_upgrade_true(self):
self.do_action_openstack_upgrade.return_value = True
self.resolve_CONFIGS.return_value = 'configs'
openstack_upgrade.openstack_upgrade()
self.do_action_openstack_upgrade.assert_called_once_with(
'openstack-dashboard',
self.do_openstack_upgrade,
'configs')
self.config_changed.assert_called_once_with()
def test_openstack_upgrade_false(self):
self.do_action_openstack_upgrade.return_value = False
self.resolve_CONFIGS.return_value = 'configs'
openstack_upgrade.openstack_upgrade()
self.do_action_openstack_upgrade.assert_called_once_with(
'openstack-dashboard',
self.do_openstack_upgrade,
'configs')
self.assertFalse(self.do_openstack_upgrade.called)
self.assertFalse(self.config_changed.called)