openstack
/
charm-ops-interface-ceph-client
Code Issues Proposed changes

Fix unit tests 

Charm helpers received some updates to support compression and rbd
mirroring options as part of pool creation requests.

Update relation test data to align with these changes.

Also drive-by add of py39 tox target.

Change-Id: Ia1c2b5d50df30156e5e56ce71eedb55c274385df
This commit is contained in:
James Page 2021-10-06 10:37:38 +01:00
parent cc4cf9d05b
commit dfafc21506
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tox.ini
View File

@ -33,6 +33,11 @@ basepython = python3.8
deps = -r{toxinidir}/test-requirements.txt
commands = stestr run {posargs}
[testenv:py39]
basepython = python3.9
deps = -r{toxinidir}/test-requirements.txt
commands = stestr run {posargs}
[testenv:pep8]
basepython = python3
deps = -r{toxinidir}/test-requirements.txt

13
unit_tests/test_interface_ceph_client.py
View File

@ -89,7 +89,17 @@ class TestCephClientRequires(unittest.TestCase):
'"replicas": 3, "pg_num": null, "weight": null, '
'"group": null, "group-namespace": null, '
'"app-name": null, '
'"max-bytes": null, "max-objects": null}, '
'"max-bytes": null, "max-objects": null, '
'"compression-algorithm": null, "compression-mode": null, '
'"compression-required-ratio": null, '
'"compression-min-blob-size": null, '
'"compression-min-blob-size-hdd": null, '
'"compression-min-blob-size-ssd": null, '
'"compression-max-blob-size": null, '
'"compression-max-blob-size-hdd": null, '
'"compression-max-blob-size-ssd": null, '
'"max-bytes": null, "max-objects": null, '
'"rbd-mirroring-mode": "pool"}, '
'{"op": "set-key-permissions", '
'"permissions": ["osd", "allow *", "mon", "allow *", '
'"mgr", '
@ -97,6 +107,7 @@ class TestCephClientRequires(unittest.TestCase):
'"request-id": "a3ad24dd-7e2f-11ea-8ba2-e5a5b68b415f"}')}}}
def setUp(self):
self.maxDiff = None
self.harness = Harness(CharmBase, meta='''
name: client
provides: