openstack
/
charm-ops-openstack
Code Issues Proposed changes

Remove duplicate on_config hook register 

CinderStoragePluginCharm should not register self.on_config
as a hook, because the parent class method already will call this
on config changed (OSBaseCharm._on_config).

(also add new tox test targets to keep zuul happy)

Change-Id: I202ad2134e6d56881213a63899e7afda1cc0de00
This commit is contained in:
Samuel Walladge 2022-06-07 12:46:48 +09:30
parent 96107db929
commit 35237c71f4
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ops_openstack/plugins/classes.py
View File

@ -61,7 +61,6 @@ class CinderStoragePluginCharm(ops_openstack.core.OSBaseCharm):
def __init__(self, framework):
super().__init__(framework)
self.framework.observe(self.on.config_changed, self.on_config)
self.framework.observe(
self.on.storage_backend_relation_changed,
self.on_storage_backend)

10
tox.ini
View File

@ -46,6 +46,16 @@ basepython = python3.8
deps = -r{toxinidir}/test-requirements.txt
commands = stestr run --slowest {posargs}
[testenv:py39]
basepython = python3.9
deps = -r{toxinidir}/test-requirements.txt
commands = stestr run --slowest {posargs}
[testenv:py310]
basepython = python3.10
deps = -r{toxinidir}/test-requirements.txt
commands = stestr run --slowest {posargs}
[testenv:pep8]
basepython = python3
deps = -r{toxinidir}/test-requirements.txt