charm-percona-cluster/170334f95258c70e01e65ae8f8bc5adebcbede2f

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "3f2bf3e0_e793d2a1",
        "filename": "/COMMIT_MSG",
        "patchSetId": 5
      },
      "lineNbr": 14,
      "author": {
        "id": 8992
      },
      "writtenOn": "2023-03-06T14:49:32Z",
      "side": 1,
      "message": "nit #2: when cherry-picking a patch, the general convention for openstack patches are to use a -x in order to preserve the source commit where the patch was cherry-picked from. While this used to be necessary to avoid a gerrit bug [0], it is something that has stuck around by convention within the community at large and is generally good practice.\n\n[0] - https://docs.openstack.org/project-team-guide/stable-branches.html#proposing-fixes",
      "revId": "170334f95258c70e01e65ae8f8bc5adebcbede2f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "3e123704_65bfe200",
        "filename": "/COMMIT_MSG",
        "patchSetId": 5
      },
      "lineNbr": 14,
      "author": {
        "id": 8992
      },
      "writtenOn": "2023-03-06T14:49:32Z",
      "side": 1,
      "message": "nit: you don\u0027t need to do the sign-off on commits to opendev, as its part of the openstack contributor agreement that you signed.",
      "revId": "170334f95258c70e01e65ae8f8bc5adebcbede2f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "b1f93a4e_4882bf9a",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 5
      },
      "lineNbr": 0,
      "author": {
        "id": 2424
      },
      "writtenOn": "2023-03-10T16:07:17Z",
      "side": 1,
      "message": "the stable/21.10 is EOL, please re-subbmit your patch targetting the stable/bionic branch.",
      "revId": "170334f95258c70e01e65ae8f8bc5adebcbede2f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ],
  "submitRequirementResults": [
    {
      "submitRequirement": {
        "name": "Backport-Candidate",
        "description": {
          "value": "Backport candidate status"
        },
        "applicabilityExpression": {
          "value": {
            "expressionString": "is:false"
          }
        },
        "submittabilityExpression": {
          "expressionString": "is:true"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {
        "value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"]}
      },
      "submittabilityExpressionResult": {},
      "overrideExpressionResult": {},
      "patchSetCommitId": "170334f95258c70e01e65ae8f8bc5adebcbede2f",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Code-Review",
        "description": {
          "value": "Code reviewed by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": true
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX","label:Code-Review=MIN"],"failingAtoms":[]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "170334f95258c70e01e65ae8f8bc5adebcbede2f",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Verified",
        "description": {
          "value": "Verified in gate by CI"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Verified=MAX","label:Verified=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "170334f95258c70e01e65ae8f8bc5adebcbede2f",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Workflow",
        "description": {
          "value": "Approved for gate by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Workflow=MAX","label:Workflow=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "170334f95258c70e01e65ae8f8bc5adebcbede2f",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    }
  ]
}