Update patch set 9
Patch Set 9: Code-Review-1 (1 comment) Patch-set: 9 Reviewer: Gerrit User 14567 <14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 1872f0e97a0a19843a6a9f1f3fd2d0e13ec71be5
This commit is contained in:
parent
113dcafaf3
commit
3a2a199553
|
@ -85,6 +85,29 @@
|
||||||
"revId": "81ca5adfac63da40cc9a53c779f5c06d992966e1",
|
"revId": "81ca5adfac63da40cc9a53c779f5c06d992966e1",
|
||||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "09564f60_18b56496",
|
||||||
|
"filename": "config.yaml",
|
||||||
|
"patchSetId": 9
|
||||||
|
},
|
||||||
|
"lineNbr": 352,
|
||||||
|
"author": {
|
||||||
|
"id": 14567
|
||||||
|
},
|
||||||
|
"writtenOn": "2024-01-05T12:43:20Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "doesn\u0027t adding a new config option with a value that differs from the default (even if the default is omitted from the config file) cause restarts? and wouldn\u0027t those restarts be disruptive? I am just a bit concerned a charm upgrade could inadvertently restart rabbit and put it into a split brain scenario, or in the best case scenario, disrupt the cloud\u0027s activity. There is no mention of caution anywhere here (although I don\u0027t fully agree it should be here, but maybe a charm guide release note patch accompaning this one perhaps).\n\nCould you please clarify?",
|
||||||
|
"range": {
|
||||||
|
"startLine": 351,
|
||||||
|
"startChar": 4,
|
||||||
|
"endLine": 352,
|
||||||
|
"endChar": 33
|
||||||
|
},
|
||||||
|
"revId": "81ca5adfac63da40cc9a53c779f5c06d992966e1",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
{
|
{
|
||||||
"unresolved": true,
|
"unresolved": true,
|
||||||
"key": {
|
"key": {
|
||||||
|
|
Loading…
Reference in New Issue