openstack
/
charm-rabbitmq-server
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
CC: Gerrit User 34913 <34913@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 935 \u003c935@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34913\u003e replied on the change"}
This commit is contained in:
Gerrit User 34913 2022-07-29 12:07:29 +00:00 committed by Gerrit Code Review
parent 2b583fdd07
commit 7e7b7659f7
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
df7bacb93df12b930d74ddbf687f51247feb1f5b
View File

@ -16,6 +16,24 @@
"message": "Generally I think this change looks OK - however considering RabbitMQ is normally run in a LXD container does enabling this check always make sense or do we need to only enable it if RMQ is running on baremetal?\n\n",
"revId": "df7bacb93df12b930d74ddbf687f51247feb1f5b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "780631c7_32edc63f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 34913
},
"writtenOn": "2022-07-29T12:07:29Z",
"side": 1,
"message": "The nrpe charm actually does not activate this check if it cannot find the cpufreq interface in sysfs in the running system:\n\nhttps://git.launchpad.net/charm-nrpe/tree/hooks/nrpe_helpers.py#n645\n\nSo as far as I understand if running on bare metal or LXD(inherits the governor value from the host), it will be enabled but for VMs it will not be. Therefore it kinda already is the case I believe?",
"parentUuid": "cad58737_cb37de2e",
"revId": "df7bacb93df12b930d74ddbf687f51247feb1f5b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}