charm-specs/181facd5d41ca30e309f5a2c85871cb771fb3e9d

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "45b04a7b_9775508c",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 34952
      },
      "writtenOn": "2024-02-26T06:28:45Z",
      "side": 1,
      "message": "Thanks Ionut, One minor doubt.\nAlso, sorry for the delay in reviewing this PR (we\u0027ve had our hands full for sometime). Please feel free to join us, give a poke and chat at https://matrix.to/#/#ubuntu-ceph:matrix.org",
      "revId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "9d574364_7aed6cd6",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 13178
      },
      "writtenOn": "2024-03-15T16:11:42Z",
      "side": 1,
      "message": "No problem! I also was busy in the previous several days. I joined the Matrix chat.",
      "parentUuid": "45b04a7b_9775508c",
      "revId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "091edc63_fdc07d73",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 34952
      },
      "writtenOn": "2024-03-21T12:50:21Z",
      "side": 1,
      "message": "LGTM",
      "revId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "3ea89747_6bfcd96c",
        "filename": "specs/2024.1/backlog/ceph-radosgw-multisite-sync-policies.rst",
        "patchSetId": 3
      },
      "lineNbr": 141,
      "author": {
        "id": 34952
      },
      "writtenOn": "2024-02-26T06:28:45Z",
      "side": 1,
      "message": "Doubt: What are the user implications of the sync policies not propagating to other RGW site ? Is it affected by directional/symmetrical nature of sync flow ?",
      "range": {
        "startLine": 140,
        "startChar": 31,
        "endLine": 141,
        "endChar": 33
      },
      "revId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e644cb27_c108949d",
        "filename": "specs/2024.1/backlog/ceph-radosgw-multisite-sync-policies.rst",
        "patchSetId": 3
      },
      "lineNbr": 141,
      "author": {
        "id": 13178
      },
      "writtenOn": "2024-03-15T16:11:42Z",
      "side": 1,
      "message": "If the sync policies are not propagated to the other RGW site, the sync would be affected only if the sync flow is symmetrical.\n\nIn the symmetrical sync flow, both sites must have sync policies to allow syncing to the other site. From an operator perspective, it is easier to manage policies from the primary units, since they will get propagated to all the secondary sites. Otherwise, you would have to make sure that you create policies on both source site, and destination site.\n\nOn the other hand, in the directional sync flow, I think it\u0027s enough to have sync policy created on the source site without it being required to be propagated to the secondary site (but I\u0027ll have to check). However, there\u0027s no problem if the policy gets propagated.\n\nI believe, it\u0027s a good choice to allow Juju actions to be run only on primary units as discussed above. This will reduce the Juju operator errors when managing policies.",
      "parentUuid": "3ea89747_6bfcd96c",
      "range": {
        "startLine": 140,
        "startChar": 31,
        "endLine": 141,
        "endChar": 33
      },
      "revId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ],
  "submitRequirementResults": [
    {
      "submitRequirement": {
        "name": "Backport-Candidate",
        "description": {
          "value": "Backport candidate status"
        },
        "applicabilityExpression": {
          "value": {
            "expressionString": "is:false"
          }
        },
        "submittabilityExpression": {
          "expressionString": "is:true"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {
        "value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"]}
      },
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Code-Review",
        "description": {
          "value": "Code reviewed by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": true
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Verified",
        "description": {
          "value": "Verified in gate by CI"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Workflow",
        "description": {
          "value": "Approved for gate by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MAX"],"failingAtoms":["label:Workflow=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "181facd5d41ca30e309f5a2c85871cb771fb3e9d",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    }
  ]
}