openstack/charm-swift-proxy
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1: Backport-Candidate+2

(3 comments)

Patch-set: 1
Label: Backport-Candidate=+2, 8508e91d2dd83ae2c29ee37b57ec0c1a0e06c262
This commit is contained in:
Gerrit User 11805 2023-10-26 12:11:41 +00:00 committed by Gerrit Code Review
parent 8946cf157e
commit ab57004fd3
2 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
5786afe3892e310c0c7095007fc9e833a5bb7de2
View File

@ -17,6 +17,24 @@
"revId": "5786afe3892e310c0c7095007fc9e833a5bb7de2", "revId": "5786afe3892e310c0c7095007fc9e833a5bb7de2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}, },
{
"unresolved": true,
"key": {
"uuid": "e3d40748_ef44ba50",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 11805
},
"writtenOn": "2023-10-26T12:11:41Z",
"side": 1,
"message": "Thanks for the review Erlon. I\u0027ve added a link to the commit message.",
"parentUuid": "897e1a37_10e6592a",
"revId": "5786afe3892e310c0c7095007fc9e833a5bb7de2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{ {
"unresolved": true, "unresolved": true,
"key": { "key": {
@ -39,6 +57,30 @@
}, },
"revId": "5786afe3892e310c0c7095007fc9e833a5bb7de2", "revId": "5786afe3892e310c0c7095007fc9e833a5bb7de2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4f65749d_c4c2bdbd",
"filename": "charmhelpers/contrib/openstack/utils.py",
"patchSetId": 1
},
"lineNbr": 579,
"author": {
"id": 11805
},
"writtenOn": "2023-10-26T12:11:41Z",
"side": 1,
"message": "That comes in from another charm-helper change that has been merged.",
"parentUuid": "9f29b7e3_d5e036a5",
"range": {
"startLine": 579,
"startChar": 3,
"endLine": 579,
"endChar": 11
},
"revId": "5786afe3892e310c0c7095007fc9e833a5bb7de2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
} }
] ]
} }

24
89d7e78998c0e67b83748fe700f0188c76f69393
View File

@ -22,6 +22,30 @@
}, },
"revId": "89d7e78998c0e67b83748fe700f0188c76f69393", "revId": "89d7e78998c0e67b83748fe700f0188c76f69393",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a509a0b4_759c9d5b",
"filename": "charmhelpers/contrib/openstack/utils.py",
"patchSetId": 1
},
"lineNbr": 427,
"author": {
"id": 11805
},
"writtenOn": "2023-10-26T12:11:41Z",
"side": 0,
"message": "Ack",
"parentUuid": "d4f1a0c5_c9b96885",
"range": {
"startLine": 419,
"startChar": 0,
"endLine": 427,
"endChar": 16
},
"revId": "89d7e78998c0e67b83748fe700f0188c76f69393",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
} }
] ]
} }