openstack/charm-swift-proxy
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1: Code-Review-1

(4 comments)

Patch-set: 1
Reviewer: Gerrit User 31203 <31203@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 5511f64be7948168d94fdbb68b7fb3b944e50c5c
This commit is contained in:
Gerrit User 31203 2024-02-12 15:07:30 +00:00 committed by Gerrit Code Review
parent e405439298
commit f83db10bab
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
ee12af86c9ace4862aa9b0be9c775cace5e82b97 Normal file
View File

@ -0,0 +1,72 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "18a25215_70060294",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 31203
},
"writtenOn": "2024-02-12T15:07:30Z",
"side": 1,
"message": "Looks good except for where the files have \"nobel\" instead of \"noble\". In addition, the file \"nobel-caracal.yaml\" needs to be renamed to \"noble-caracal.yaml\"",
"revId": "ee12af86c9ace4862aa9b0be9c775cace5e82b97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "00036961_87ee2441",
"filename": "tests/bundles/nobel-caracal.yaml",
"patchSetId": 1
},
"lineNbr": 4,
"author": {
"id": 31203
},
"writtenOn": "2024-02-12T15:07:30Z",
"side": 1,
"message": "\"noble\" instead of \"nobel\"",
"revId": "ee12af86c9ace4862aa9b0be9c775cace5e82b97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "25c2f8c6_8f93f303",
"filename": "tests/tests.yaml",
"patchSetId": 1
},
"lineNbr": 8,
"author": {
"id": 31203
},
"writtenOn": "2024-02-12T15:07:30Z",
"side": 1,
"message": "\"noble-caracal\" instead of \"nobel-caracal\"",
"revId": "ee12af86c9ace4862aa9b0be9c775cace5e82b97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cffd26c6_c2cdfb68",
"filename": "tests/tests.yaml",
"patchSetId": 1
},
"lineNbr": 29,
"author": {
"id": 31203
},
"writtenOn": "2024-02-12T15:07:30Z",
"side": 1,
"message": "\"noble-caracal\" instead of \"nobel-caracal\"",
"revId": "ee12af86c9ace4862aa9b0be9c775cace5e82b97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}