d3fbe00f1d
Patch Set 2:
(1 comment)
Patch-set: 2
Attention: {"person_ident":"Gerrit User 11805 \u003c11805@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_2424\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 2424 \u003c2424@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_2424\u003e replied on the change"}
56 lines
2.1 KiB
Plaintext
56 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c8fd04e9_a4cb35b8",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 10058
|
|
},
|
|
"writtenOn": "2023-11-03T13:29:03Z",
|
|
"side": 1,
|
|
"message": "I believe that the results are basically the same but, you should be backporting this from the gerrit change that was merged or master, not pulling from the merged pull request on github. This goes for the whole series on swift updates[1].\n\n[1] https://review.opendev.org/q/Enable+swift+payload+upgrades+for+wallaby",
|
|
"revId": "50afeb19cf01e1834644464873cc8c1949d81201",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "90c8e046_69e67de4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11805
|
|
},
|
|
"writtenOn": "2023-11-03T14:22:31Z",
|
|
"side": 1,
|
|
"message": "charm-helpers gets into a strange area where we maintain stable charm-helper branches. So I think the right way is to sync from the stable charm-helper branch instead of cherry-picking. Maybe someone else can confirm or deny.",
|
|
"revId": "50afeb19cf01e1834644464873cc8c1949d81201",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0de81031_947e51a7",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 2424
|
|
},
|
|
"writtenOn": "2023-11-03T14:24:56Z",
|
|
"side": 1,
|
|
"message": "\u003e So I think the right way is to sync from the stable charm-helper branch instead of cherry-picking. \n\nthis is correct, the cherry-pick happens on charm-helpers, while on the charm side we only do \"make sync\" from the branch where the cherry-pick got merged.",
|
|
"parentUuid": "90c8e046_69e67de4",
|
|
"revId": "50afeb19cf01e1834644464873cc8c1949d81201",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |