charm-swift-storage/d70a31ed666f796d2414c049e3e...

57 lines
1.7 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "5c310bbf_20fd8ef2",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1131
},
"writtenOn": "2023-12-06T22:30:26Z",
"side": 1,
"message": "lgtm, but this will need to merge before the dependent patch listed as that one can\u0027t pass the gate",
"revId": "d70a31ed666f796d2414c049e3e7e9656384a100",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "431047fa_64490f19",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 11805
},
"writtenOn": "2023-12-07T13:13:32Z",
"side": 1,
"message": "Ah that\u0027s right. They both have a dependency on each other in order for tests to pass so I think the only option is to land them together in the same commit. Thoughts?",
"parentUuid": "5c310bbf_20fd8ef2",
"revId": "d70a31ed666f796d2414c049e3e7e9656384a100",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e4eda90f_d02ba7b8",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1131
},
"writtenOn": "2023-12-07T16:13:17Z",
"side": 1,
"message": "Oh, if this can\u0027t stand on it\u0027s own then I think we should add it to the other change.",
"parentUuid": "431047fa_64490f19",
"revId": "d70a31ed666f796d2414c049e3e7e9656384a100",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}