Update patch set 14
Patch Set 14: (9 comments) Patch-set: 14 Attention: {"person_ident":"Gerrit User 36623 \u003c36623@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36623\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 935 \u003c935@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36623\u003e replied on the change"}
This commit is contained in:
parent
d74c0c3998
commit
110384dd63
@ -34,6 +34,24 @@
|
||||
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "c1863aec_25592b2b",
|
||||
"filename": "src/README.md",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 244,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "I removed this part from doc, But I did not understand to which section of main Openstack Charm Guide I should add it.\n\nhttps://review.opendev.org/c/openstack/charm-guide/+/905611 is the doc update",
|
||||
"parentUuid": "da3ba781_91eccc57",
|
||||
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@ -50,6 +68,24 @@
|
||||
"message": "Please can you wrap the text to be less that 79 chars.",
|
||||
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "ba48caa9_4a5aca30",
|
||||
"filename": "src/actions.yaml",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 117,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "I updated but also updated other lines exceeding 79 bytes.",
|
||||
"parentUuid": "40e6bef0_226d8504",
|
||||
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
@ -16,6 +16,24 @@
|
||||
"message": "Needs an update for the wording:\n\nProvide an alternative URL for the Certificate Revocation List (CRL) distribution point that is included in all certificates issued by Vault. This relies on an external process to synchronise certificates revoked in Vault to this external distribution point and should only be used when the Vault infrastructure is not generally accessible to client endpoints used to access services secured by the Vault Intermediate CA.",
|
||||
"revId": "958390ab9c7fdcd8ff24ce2410a8664d442c1e3f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "c5581c92_ee0b7bfe",
|
||||
"filename": "src/actions.yaml",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 114,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "ff5ea6f8_6cb69ee9",
|
||||
"revId": "958390ab9c7fdcd8ff24ce2410a8664d442c1e3f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
@ -33,6 +33,23 @@
|
||||
"message": "wrong PR",
|
||||
"revId": "aa02567383117f98633828952c60792ee7ace1a1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3e7c01f7_d2f3d3b0",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "charm-recheck",
|
||||
"revId": "aa02567383117f98633828952c60792ee7ace1a1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
@ -47,6 +47,30 @@
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "4e163bc2_ec9f7dd5",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 8,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "16e3aed9_d46b80ff",
|
||||
"range": {
|
||||
"startLine": 6,
|
||||
"startChar": 0,
|
||||
"endLine": 8,
|
||||
"endChar": 0
|
||||
},
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
@ -87,6 +111,30 @@
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "2d178d69_3d99a670",
|
||||
"filename": "src/actions.yaml",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 110,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "93a24837_71b28a0a",
|
||||
"range": {
|
||||
"startLine": 110,
|
||||
"startChar": 4,
|
||||
"endLine": 110,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@ -110,6 +158,30 @@
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "ca78e4bf_c393e1d2",
|
||||
"filename": "src/actions.yaml",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 112,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "c4a2db20_9b73746e",
|
||||
"range": {
|
||||
"startLine": 112,
|
||||
"startChar": 0,
|
||||
"endLine": 112,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@ -173,6 +245,48 @@
|
||||
},
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "43d77983_335334e5",
|
||||
"filename": "src/lib/charm/vault_pki.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 206,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "Customer returned with a reply that \"We are fine with a single URI as CDP, as long as the URI could be resolved and reachable from all the systems we are fine with it.\"",
|
||||
"parentUuid": "d90ea1e8_e2babb72",
|
||||
"range": {
|
||||
"startLine": 206,
|
||||
"startChar": 41,
|
||||
"endLine": 206,
|
||||
"endChar": 42
|
||||
},
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f2e07fbb_339f009f",
|
||||
"filename": "src/lib/charm/vault_pki.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 206,
|
||||
"author": {
|
||||
"id": 36623
|
||||
},
|
||||
"writtenOn": "2024-01-17T20:07:22Z",
|
||||
"side": 1,
|
||||
"message": "Hi Alex, this was smt I added but when I removed last commit I lost this change. Do you want me to do this \"Optional\" tag for all other actions also? Because in none Optional explanation was given.",
|
||||
"parentUuid": "b322089b_4fee06a9",
|
||||
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user