openstack/charms.ceph
Code Issues Proposed changes

Update patch set 9

Browse Source 
Patch Set 9: Code-Review-1

(1 comment)

LGTM, just one typo left, my mistake, but I think it's hard to understand what we mean if we leave this typo. Happy to land once fixed!

Patch-set: 9
Reviewer: Gerrit User 31289 <31289@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 31289 2021-07-22 13:11:52 +00:00 committed by Gerrit Code Review
parent 7d30b98750
commit 34c2697029
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
e68fc4ef1c65eec72333f7200bbc180481a970d4 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "163f28e0_af79499e",
"filename": "charms_ceph/utils.py",
"patchSetId": 9
},
"lineNbr": 582,
"author": {
"id": 31289
},
"writtenOn": "2021-07-22T13:11:52Z",
"side": 1,
"message": "Sorry I made myself a typo, \"on\" instead of \"or\". It should be \"can be direct or inherited from ancestors\"",
"revId": "e68fc4ef1c65eec72333f7200bbc180481a970d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}