Update patch set 7
Patch Set 7: > Patch Set 7: > > > Hi Alex, I didn't mean to point out that you didn't test it. > > No, really, I should have checked it first; otherwise, I was just creating work for you, for which I'm sorry. > No problem, It was too late for me so I just copied your suggestion to the test script. > > > > I see that your version has more smaller steps, which makes it easier to understand. I have no strong opinion here. > > If you agree and prefer your version, I will implement it in the morning. > > It was mostly me checking what the algorithm is. I'm obviously biased, so I think we should leave it to Aurelien to decide which algorithm best represents the code as he understands it (as effectively, he is reviewing both bits of code). > Me too and I agree to leave this decision to Aurelien. > Thanks again for working on this and through the review comments. Thank you for your patience in this review. I should spend more time on docstring and functions/variables names. Patch-set: 7
This commit is contained in:
parent
7eecf4b768
commit
88e35c05a0