Patch Set 7:
> Hi Alex, I didn't mean to point out that you didn't test it.
No, really, I should have checked it first; otherwise, I was just creating work for you, for which I'm sorry.
>
> I see that your version has more smaller steps, which makes it easier to understand. I have no strong opinion here.
> If you agree and prefer your version, I will implement it in the morning.
It was mostly me checking what the algorithm is. I'm obviously biased, so I think we should leave it to Aurelien to decide which algorithm best represents the code as he understands it (as effectively, he is reviewing both bits of code).
Thanks again for working on this and through the review comments.
Patch-set: 7
Reviewer: Gerrit User 20870 <20870@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
7eecf4b768