109 lines
4.0 KiB
Plaintext
109 lines
4.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "bb57d068_4d18f90d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 13425
|
|
},
|
|
"writtenOn": "2023-02-09T14:28:38Z",
|
|
"side": 1,
|
|
"message": "I thought the current PowerFlex driver could only create volumes that were rounded to 8Gb anyway:https://github.com/openstack/cinder/blob/393c2e4ad90c05ebf28cc3a2c65811d7e1e0bc18/cinder/volume/drivers/dell_emc/powerflex/options.py#L109\nso there currently is no way to create a 5GB volume and extend to 7GB as the inital 5GB creation would fail. This means that there is no need for this.\nPlus, I am only aware of PowerFlex having size rounding requirements, so this seems a lot of trouble in core code for one vendor specific \u0027feature\u0027.\n-1 so you can comment.",
|
|
"revId": "d614688d8b1c3c24235d131015cf269bd3dd833d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "44e04a68_49c2243b",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31779
|
|
},
|
|
"writtenOn": "2023-02-09T14:32:51Z",
|
|
"side": 1,
|
|
"message": "Hi Simon, you are right, powerflex uses 8GB only as volume size.\nThe need here is to have both sizes (what the user wants, and what is actually allocated on the backend) displayed to the user.\nWe have discussed it in our PTG, and it was the solution that we all agreed. Let me know I have misunderstood.",
|
|
"parentUuid": "bb57d068_4d18f90d",
|
|
"revId": "d614688d8b1c3c24235d131015cf269bd3dd833d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a7cb7baf_7da5edd7",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 13425
|
|
},
|
|
"writtenOn": "2023-02-09T14:42:07Z",
|
|
"side": 1,
|
|
"message": "OK - I didn\u0027t attend the PTG so wasn\u0027t aware of this discussion.\nIf the rest of the team are happy with it, then I\u0027ll remove my -1 and review the spec again.",
|
|
"parentUuid": "44e04a68_49c2243b",
|
|
"revId": "d614688d8b1c3c24235d131015cf269bd3dd833d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "279b1cc1_b42bf9ed",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31779
|
|
},
|
|
"writtenOn": "2023-02-09T14:44:49Z",
|
|
"side": 1,
|
|
"message": "thank you, let\u0027s wait for the rest of team to give their feedback. Then we can decide whether or not to proceed.",
|
|
"parentUuid": "a7cb7baf_7da5edd7",
|
|
"revId": "d614688d8b1c3c24235d131015cf269bd3dd833d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "957aeecc_ff69ae2c",
|
|
"filename": "specs/untargeted/sizing-capacity-rounded-volumes.rst",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 64,
|
|
"author": {
|
|
"id": 13425
|
|
},
|
|
"writtenOn": "2023-04-26T17:09:26Z",
|
|
"side": 1,
|
|
"message": "Have you confirmed that this change does not affect any other vendors?",
|
|
"revId": "d614688d8b1c3c24235d131015cf269bd3dd833d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "685e00f2_916b5e9f",
|
|
"filename": "specs/untargeted/sizing-capacity-rounded-volumes.rst",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 69,
|
|
"author": {
|
|
"id": 30615
|
|
},
|
|
"writtenOn": "2023-03-21T18:59:59Z",
|
|
"side": 1,
|
|
"message": "Dataverse or dataV right?",
|
|
"revId": "d614688d8b1c3c24235d131015cf269bd3dd833d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |