openstack
/
cinder-tempest-plugin
Code Issues Proposed changes

GET backup before asserting 'volume_id' and 'snapshot_id' 

Recently, commit c96757b275 was merged
to remove redundant cleanups in volume backup tests. But there was a
bug in the change that assumed 'volume_id' and 'snapshot_id' are
returned from the backup create API when they are not.

We need to GET the backup in the API in order to obtain the 'volume_id'
and 'snapshot_id' for the asserts.

Closes-Bug: #1796207

Change-Id: I640fe41ec6049bfd980dfcbb6cae95a9a3e97b66
This commit is contained in:
melanie witt 2018-10-04 23:47:12 +00:00
parent 9540ed07ab
commit e935d35956
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cinder_tempest_plugin/api/volume/test_volume_backup.py
View File

@ -41,6 +41,9 @@ class VolumesBackupsTest(base.BaseVolumeTest):
backup = self.create_backup(
volume_id=volume['id'],
snapshot_id=snapshot['id'])
# Get a given backup. We need to do this to get the volume_id and
# snapshot_id of the backup. They are not returned by the create API.
backup = self.backups_client.show_backup(backup['id'])['backup']
self.assertEqual(volume['id'], backup['volume_id'])
self.assertEqual(snapshot['id'], backup['snapshot_id'])