openstack
/
cinder
Code Issues Proposed changes

Remove unused kill method from Service 

In Service class we have a kill method that must have been inherited
from Nova code and that is not currently being used anywhere.

This patch removes this method instead of making it execute on SIGKILL
to preserve current behavior.

Change-Id: I50138d815ac93b171f246f4ecee9d1da1799e00d
This commit is contained in:
Gorka Eguileor 2016-02-16 19:09:16 +01:00
parent 598e35c337
commit 010df28d76
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cinder/service.py
View File

@ -263,16 +263,6 @@ class Service(service.Service):
return service_obj
def kill(self):
"""Destroy the service object in the datastore."""
self.stop()
try:
service_ref = objects.Service.get_by_id(
context.get_admin_context(), self.service_id)
service_ref.destroy()
except exception.NotFound:
LOG.warning(_LW('Service killed that has no database entry'))
def stop(self):
# Try to shut the connection down, but if we get any sort of
# errors, go ahead and ignore them.. as we're shutting down anyway