From 09b1b1351901b5cf042b2a59624751451707c87a Mon Sep 17 00:00:00 2001 From: rajinir Date: Mon, 2 Oct 2017 16:22:18 -0500 Subject: [PATCH] Dell EMC PS: Fix extend volume creating unmanaged snapsots The Dell EMC PS driver's extend volume code is missing the no-snap option and creates unmanaged snapshots in the background. Added that option to fix it. Closes Bug: #1720454 Change-Id: I48398331fe086760a88bd5ca4c0f28f90e22bd0b (cherry picked from commit 0910706e762cec88a2b53e82bd7e6a1c372163b9) --- cinder/volume/drivers/dell_emc/ps.py | 5 +++-- .../notes/ps-extend_volume-no-snap-8aa447c50f2475a7.yaml | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/ps-extend_volume-no-snap-8aa447c50f2475a7.yaml diff --git a/cinder/volume/drivers/dell_emc/ps.py b/cinder/volume/drivers/dell_emc/ps.py index 906e6905020..a0d8a013e05 100644 --- a/cinder/volume/drivers/dell_emc/ps.py +++ b/cinder/volume/drivers/dell_emc/ps.py @@ -136,10 +136,11 @@ class PSSeriesISCSIDriver(san.SanISCSIDriver): 1.4.1 - Rebranded driver to Dell EMC. 1.4.4 - Fixed over-subscription ratio calculation 1.4.5 - Optimize volume stats information parsing + 1.4.6 - Extend volume with no-snap option """ - VERSION = "1.4.5" + VERSION = "1.4.6" # ThirdPartySytems wiki page CI_WIKI_NAME = "Dell_Storage_CI" @@ -608,7 +609,7 @@ class PSSeriesISCSIDriver(san.SanISCSIDriver): """Extend the size of the volume.""" try: self._eql_execute('volume', 'select', volume['name'], - 'size', "%sG" % new_size) + 'size', "%sG" % new_size, 'no-snap') LOG.info(_LI('Volume %(name)s resized from ' '%(current_size)sGB to %(new_size)sGB.'), {'name': volume['name'], diff --git a/releasenotes/notes/ps-extend_volume-no-snap-8aa447c50f2475a7.yaml b/releasenotes/notes/ps-extend_volume-no-snap-8aa447c50f2475a7.yaml new file mode 100644 index 00000000000..f64055e03da --- /dev/null +++ b/releasenotes/notes/ps-extend_volume-no-snap-8aa447c50f2475a7.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - Dell EMC PS Series Driver was creating unmanaged snapshots + when extending volumes. Fixed it by adding the missing + no-snap parameter. This change fixes bug 1720454.