openstack
/
cinder
Code Issues Proposed changes

Ensure pep8/fast8 run in python 3.6 

Running pep8 under py38 is resulting in "AttributeError:
'FlakesChecker' object has no attribute 'CONSTANT'".  The least
intrusive fix seems to be to pin the tox pep8/fast8 testenvs to
python3.6.  Also, keep pycodestyle under 2.6.0 so we don't have to
make any purely stylistic changes in stable/train to get pep8 to
pass.

Change-Id: I17b30c43aa00214d56c51bde3b9d43c0db1695ac
This commit is contained in:
Brian Rosmaita 2021-01-19 16:08:54 -05:00
parent 60a7361091
commit 0c5406da76
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test-requirements.txt
View File

@ -11,7 +11,7 @@ fixtures>=3.0.0 # Apache-2.0/BSD
mock>=2.0.0 # BSD
os-api-ref>=1.4.0 # Apache-2.0
oslotest>=3.2.0 # Apache-2.0
pycodestyle>=2.0.0 # MIT License
pycodestyle>=2.0.0,<2.6.0 # MIT License
PyMySQL>=0.7.6 # MIT License
psycopg2>=2.7 # LGPL/ZPL
SQLAlchemy-Utils>=0.33.11 # BSD License

4
tox.ini
View File

@ -73,7 +73,7 @@ setenv =
OS_TEST_PATH = ./cinder/tests/compliance
[testenv:pep8]
basepython = python3
basepython = python3.6
commands =
flake8 {posargs} .
doc8
@ -81,7 +81,7 @@ commands =
{toxinidir}/tools/check_exec.py {toxinidir}/cinder {toxinidir}/doc/source/ {toxinidir}/releasenotes/notes
[testenv:fast8]
basepython = python3
basepython = python3.6
# Use same environment directory as pep8 env to save space and install time
envdir = {toxworkdir}/pep8
commands =