From ec1812c285b4367f439a65f66db2599bd4200357 Mon Sep 17 00:00:00 2001 From: Eric Harney Date: Tue, 26 Jul 2022 09:24:22 -0400 Subject: [PATCH] Clear up _reschedule() return value Per I8516178941, create_volume here doesn't return anything. Make this more clear. Depends-On: I851617894157d9fcb14b1e1294ac8b39c4a7a558 Change-Id: I612bd1c3e200554d4d6e687fa2aee802951a1f48 --- cinder/volume/flows/manager/create_volume.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cinder/volume/flows/manager/create_volume.py b/cinder/volume/flows/manager/create_volume.py index 782b991f6cd..dbcf1f23b87 100644 --- a/cinder/volume/flows/manager/create_volume.py +++ b/cinder/volume/flows/manager/create_volume.py @@ -145,7 +145,7 @@ class OnFailureRescheduleTask(flow_utils.CinderTask): volume.id) def _reschedule(self, context, cause, request_spec, filter_properties, - volume): + volume) -> None: """Actions that happen during the rescheduling attempt occur here.""" create_volume = self.scheduler_rpcapi.create_volume @@ -169,8 +169,8 @@ class OnFailureRescheduleTask(flow_utils.CinderTask): # Stringify to avoid circular ref problem in json serialization retry_info['exc'] = traceback.format_exception(*cause.exc_info) - return create_volume(context, volume, request_spec=request_spec, - filter_properties=filter_properties) + create_volume(context, volume, request_spec=request_spec, + filter_properties=filter_properties) def _post_reschedule(self, volume): """Actions that happen after the rescheduling attempt occur here."""