Merge "NetApp NFS ONTAP: Deprecate Copy Offload Tool"

cinder/volume/drivers/netapp/dataontap/nfs_base.py

@@ -31,6 +31,7 @@ import time
 from oslo_concurrency import processutils
 from oslo_config import cfg
 from oslo_log import log as logging
+from oslo_log import versionutils
 from oslo_utils import netutils
 from oslo_utils import units
 import six
@@ -675,6 +676,11 @@ class NetAppNfsDriver(driver.ManageableVD,
         major, minor = self.zapi_client.get_ontapi_version()
         col_path = self.configuration.netapp_copyoffload_tool_path
 
+        if col_path:
+            msg = ('The "netapp_copyoffload_tool_path" configuration option '
+                   'is deprecated and will be removed soon. Please, do not '
+                   'set it.')
+            versionutils.report_deprecated_feature(LOG, msg)
         try:
             cache_result = self._find_image_in_cache(image_id)
             if cache_result:

cinder/volume/drivers/netapp/options.py

@@ -129,7 +129,10 @@ netapp_nfs_extra_opts = [
                help=('This option specifies the path of the NetApp copy '
                      'offload tool binary. Ensure that the binary has execute '
                      'permissions set which allow the effective user of the '
-                     'cinder-volume process to execute the file.')), ]
+                     'cinder-volume process to execute the file.'),
+               deprecated_for_removal=True,
+               deprecated_reason='The CopyOfflload tool is no longer '
+                                 'available for downloading.'), ]
 netapp_san_opts = [
     cfg.StrOpt('netapp_lun_ostype',
                help=('This option defines the type of operating system that'

releasenotes/notes/netapp-nfs-deprecate-copy-offload-option-f9d6fe8e3dfafb04.yaml

@@ -0,0 +1,5 @@
+---
+deprecations:
+  - |
+    Deprecate NetApp NFS option `netapp_copyoffload_tool_path`. The tool is no longer
+    available for downloading.